From: Dave Chinner <david@fromorbit.com>
To: Eric Whitney <enwlinux@gmail.com>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH] xfstests-bld: add exclude file for data_journal_noleak tests
Date: Wed, 13 Jan 2016 07:35:54 +1100 [thread overview]
Message-ID: <20160112203554.GH6033@dastard> (raw)
In-Reply-To: <20160112195248.GA1941@localhost.localdomain>
On Tue, Jan 12, 2016 at 02:52:48PM -0500, Eric Whitney wrote:
> Duplicate the contents of the data_journal exclude file for the
> data_journal_noleak test case. This will prevent failure reports from
> tests already known to exercise unsupported online defrag functionality.
> Add an explanatory comment to both exclude files for future reference.
>
> Signed-off-by: Eric Whitney <enwlinux@gmail.com>
Can you please make these changes directly to xfstests rather than
keeping information about what tests run under what circumstances in
some external test wrapper? i.e. this can be implementing by adding
a _requires_no_data_journal() check and adding it to each test.
That way every one who runs xfstests on ext4 benefit from this
exclusion, rather than just kvm-xfstests users.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2016-01-12 20:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 19:52 [PATCH] xfstests-bld: add exclude file for data_journal_noleak tests Eric Whitney
2016-01-12 20:35 ` Dave Chinner [this message]
2016-01-13 16:55 ` Theodore Ts'o
2016-01-18 22:16 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160112203554.GH6033@dastard \
--to=david@fromorbit.com \
--cc=enwlinux@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).