From: Theodore Ts'o <tytso@mit.edu>
To: Eric Whitney <enwlinux@gmail.com>
Cc: linux-ext4@vger.kernel.org, jack@suse.cz
Subject: Re: [PATCH] ext4: revert i_data_sum locking cleanups for dioread_nolock
Date: Tue, 16 Feb 2016 00:08:40 -0500 [thread overview]
Message-ID: <20160216050840.GA3426@thunk.org> (raw)
In-Reply-To: <20160212182506.GB1592@localhost.localdomain>
On Fri, Feb 12, 2016 at 01:25:06PM -0500, Eric Whitney wrote:
> Commit 2bcba4781fa3 ("ext4: get rid of EXT4_GET_BLOCKS_NO_LOCK flag")
> can cause a kernel panic when xfstest generic/300 is run on a file
> system mounted with dioread_nolock. The panic is typically triggered
> from check_irqs_on() (fs/buffer.c: 1272), and happens because
> ext4_end_io_dio() is being called in an interrupt context rather than
> from a workqueue for AIO. This suggests that buffer_defer_completion
> may not be set properly when creating an unwritten extent for async
> direct I/O.
>
> Revert the locking changes until this problem can be resolved. Patch
> applied to 4.5-rc3 and tested with a full xfstest-bld auto group run.
>
> Signed-off-by: Eric Whitney <enwlinux@gmail.com>
Applied, thanks.
I was able to reliably reproduce the problem without this revert patch
using a 32-bit x86 kvm-xfstests test appliance:
ftp://ftp.kernel.org/pub/linux/kernel/people/tytso/kvm-xfstests/testing/root_fs.img.i386
Using the command: "kvm-xfstests -c dioread_nolock generic/300"
With this patch, the problem goes away, so reverting the patch is
clearly the right thing for now. There is something screwy going on,
since the original commit shouldn't have made a difference, but let's
revert it first, and figure it out when we have time to investigate
more deeply.
- Ted
next prev parent reply other threads:[~2016-02-16 5:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 18:25 [PATCH] ext4: revert i_data_sum locking cleanups for dioread_nolock Eric Whitney
2016-02-16 5:08 ` Theodore Ts'o [this message]
2016-02-18 22:09 ` Jan Kara
2016-02-19 5:30 ` Theodore Ts'o
2016-02-19 14:19 ` Eric Whitney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160216050840.GA3426@thunk.org \
--to=tytso@mit.edu \
--cc=enwlinux@gmail.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).