From: Theodore Ts'o <tytso@mit.edu>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2] ext4: Prevent panic for destroyed devices
Date: Fri, 19 Feb 2016 00:13:34 -0500 [thread overview]
Message-ID: <20160219051334.GC12743@thunk.org> (raw)
In-Reply-To: <87d1ru2wex.fsf@openvz.org>
On Thu, Feb 18, 2016 at 12:35:34PM +0300, Dmitry Monakhov wrote:
> Hm...
> Actually there are many places where we submit BHs w/o checks
> nojournal code is full of such places.
> It looks like we need some sort of AOP_TRUNCATE_PAGE error code
> for generic buffer submission path
Might it be enough to simply return have submit_bh check for the
unmapped buffer and return EIO? I'm not sure we need a magic error
code....
That being said, I've always wished that there was a struct super
operation, s_block_device_gone() that would allow information about
the status of the block device to be communicated up the storage
stack. Another useful thing that might be useful is an indication
that for whatever reason, the storage device has turned read-only on
us (so we might as well remounte the file system read-only instead of
letting userspace continue to dirty pages that have no hope of getting
written out).
- Ted
next prev parent reply other threads:[~2016-02-19 5:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 10:36 [PATCH 1/2] ext4: Prevent panic for destroyed devices Dmitry Monakhov
2016-02-16 10:36 ` [PATCH 2/2] jbd2: " Dmitry Monakhov
2016-03-13 22:28 ` Theodore Ts'o
2016-02-18 9:35 ` [PATCH 1/2] ext4: " Dmitry Monakhov
2016-02-19 5:13 ` Theodore Ts'o [this message]
2016-03-13 22:26 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160219051334.GC12743@thunk.org \
--to=tytso@mit.edu \
--cc=dmonakhov@openvz.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).