From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@infradead.org>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: use directio end_io error status to finish unwritten aio dio correctly
Date: Fri, 19 Feb 2016 10:15:48 -0500 [thread overview]
Message-ID: <20160219151548.GB3014@thunk.org> (raw)
In-Reply-To: <20160219131829.GA30166@quack.suse.cz>
On Fri, Feb 19, 2016 at 02:18:29PM +0100, Jan Kara wrote:
> Yeah, if IO error occurs while writing to unwritten extent we need to just
> destroy the IO end without doing the extent conversion (since we don't know
> how much got written). Attached patch should fix the issue - full xfstests
> run is in progress but a quick check using generic/299 has passed.
>
> How do we merge this? It depends on the changes in Dave's tree so do we
> merge it via that? I have other ext4 changes pending in this area so Ted
> would then have to pull some branch from Dave's tree. Guys?
I've been asking Darrick this on the weekly ext4 teleconference for a
while. If DIO changes can be put this on a separate git branch, we
can merge it that way. Worse case, the DIO fix can go in during the
next merge window, and then the ext4 fixup can go in post rc2. After
all, we've been living this for a while...
- Ted
next prev parent reply other threads:[~2016-02-19 15:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 5:45 [PATCH] ext4: use directio end_io error status to finish unwritten aio dio correctly Darrick J. Wong
2016-02-18 6:01 ` Christoph Hellwig
2016-02-18 21:30 ` Jan Kara
2016-02-18 22:02 ` Dave Chinner
2016-02-19 13:18 ` Jan Kara
2016-02-19 15:15 ` Theodore Ts'o [this message]
2016-02-21 6:28 ` Dave Chinner
2016-02-22 8:19 ` Jan Kara
2016-02-22 20:11 ` Darrick J. Wong
2016-02-22 8:56 ` Christoph Hellwig
2016-02-29 7:03 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160219151548.GB3014@thunk.org \
--to=tytso@mit.edu \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).