From: Dave Chinner <david@fromorbit.com>
To: Eric Whitney <enwlinux@gmail.com>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH] xfstests-bld: add exclude file for ext3 tests
Date: Sun, 21 Feb 2016 11:34:11 +1100 [thread overview]
Message-ID: <20160221003411.GZ14668@dastard> (raw)
In-Reply-To: <20160220155157.GA19420@localhost.localdomain>
On Sat, Feb 20, 2016 at 10:51:57AM -0500, Eric Whitney wrote:
> Add an exclude file for the ext3 test case to prevent failure reports
> from tests that exercise unsupported online defrag functionality.
ext3 should not run these tests because of the _requires_defrag
check in these tests results in a _notrun command being run
when FSTYP=ext3.
> Two online defrag tests - ext4/307 and /308 - are not included because
> they contain explicit requirements for fallocate support that prevents
> them from running on an emulated ext3 file system.
Same here.
> It may be possible to modify the excluded tests at a future date so they
> will not run unless the test file system is extent mapped. For now, this
> patch is an expedient measure to reduce testing noise.
>
> Signed-off-by: Eric Whitney <enwlinux@gmail.com>
> ---
> kvm-xfstests/test-appliance/files/root/conf/ext3.exclude | 6 ++++++
> 1 file changed, 6 insertions(+)
> create mode 100644 kvm-xfstests/test-appliance/files/root/conf/ext3.exclude
>
> diff --git a/kvm-xfstests/test-appliance/files/root/conf/ext3.exclude b/kvm-xfstests/test-appliance/files/root/conf/ext3.exclude
> new file mode 100644
> index 0000000..c46c79b
> --- /dev/null
> +++ b/kvm-xfstests/test-appliance/files/root/conf/ext3.exclude
> @@ -0,0 +1,6 @@
> +# ext4's ext3 emulation does not support on-line
> +# defrag, which requires extent-based files
> +ext4/301
> +ext4/302
> +ext4/303
> +ext4/304
So what we really need to understand is why _require_defrag is not
preventing these tests beign run on an ext3 filesystem?
Eric, what is the output of these tests when it is run on an ext3
filesytsem? What is the fstyp you are testing?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2016-02-21 0:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-20 15:51 [PATCH] xfstests-bld: add exclude file for ext3 tests Eric Whitney
2016-02-21 0:34 ` Dave Chinner [this message]
2016-02-21 2:57 ` Theodore Ts'o
2016-02-21 5:45 ` Theodore Ts'o
2016-02-21 6:23 ` Dave Chinner
2016-02-21 16:58 ` Theodore Ts'o
2016-02-22 0:26 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160221003411.GZ14668@dastard \
--to=david@fromorbit.com \
--cc=enwlinux@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox