From: kbuild test robot <lkp@intel.com>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: kbuild-all@01.org, Theodore Ts'o <tytso@mit.edu>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] ext4/jbd2: Fix jbd2_journal_destory() for umount path
Date: Thu, 25 Feb 2016 21:11:19 +0800 [thread overview]
Message-ID: <201602252133.1j77g0Iw%fengguang.wu@intel.com> (raw)
In-Reply-To: <87fuwh58ro.fsf@mail.parknet.co.jp>
[-- Attachment #1: Type: text/plain, Size: 5617 bytes --]
Hi OGAWA,
[auto build test WARNING on ext4/dev]
[also build test WARNING on v4.5-rc5 next-20160224]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
url: https://github.com/0day-ci/linux/commits/OGAWA-Hirofumi/ext4-jbd2-Fix-jbd2_journal_destory-for-umount-path/20160225-195750
base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
reproduce: make htmldocs
All warnings (new ones prefixed by >>):
include/linux/jbd2.h:434: warning: No description found for parameter 'i_transaction'
include/linux/jbd2.h:434: warning: No description found for parameter 'i_next_transaction'
include/linux/jbd2.h:434: warning: No description found for parameter 'i_list'
include/linux/jbd2.h:434: warning: No description found for parameter 'i_vfs_inode'
include/linux/jbd2.h:434: warning: No description found for parameter 'i_flags'
include/linux/jbd2.h:490: warning: No description found for parameter 'h_rsv_handle'
include/linux/jbd2.h:490: warning: No description found for parameter 'h_reserved'
include/linux/jbd2.h:490: warning: No description found for parameter 'h_type'
include/linux/jbd2.h:490: warning: No description found for parameter 'h_line_no'
include/linux/jbd2.h:490: warning: No description found for parameter 'h_start_jiffies'
include/linux/jbd2.h:490: warning: No description found for parameter 'h_requested_credits'
include/linux/jbd2.h:490: warning: No description found for parameter 'h_lockdep_map'
include/linux/jbd2.h:1033: warning: No description found for parameter 'j_chkpt_bhs[JBD2_NR_BATCH]'
include/linux/jbd2.h:1033: warning: No description found for parameter 'j_devname[BDEVNAME_SIZE+24]'
include/linux/jbd2.h:1033: warning: No description found for parameter 'j_average_commit_time'
include/linux/jbd2.h:1033: warning: No description found for parameter 'j_min_batch_time'
include/linux/jbd2.h:1033: warning: No description found for parameter 'j_max_batch_time'
include/linux/jbd2.h:1033: warning: No description found for parameter 'j_commit_callback'
include/linux/jbd2.h:1033: warning: No description found for parameter 'j_failed_commit'
include/linux/jbd2.h:1033: warning: No description found for parameter 'j_chksum_driver'
include/linux/jbd2.h:1033: warning: No description found for parameter 'j_csum_seed'
include/linux/jbd2.h:1033: warning: Excess struct/union/enum/typedef member 'j_history' description in 'journal_s'
include/linux/jbd2.h:1033: warning: Excess struct/union/enum/typedef member 'j_history_max' description in 'journal_s'
include/linux/jbd2.h:1033: warning: Excess struct/union/enum/typedef member 'j_history_cur' description in 'journal_s'
>> fs/jbd2/journal.c:1438: warning: No description found for parameter 'write_op'
fs/jbd2/transaction.c:429: warning: No description found for parameter 'rsv_blocks'
fs/jbd2/transaction.c:429: warning: No description found for parameter 'gfp_mask'
fs/jbd2/transaction.c:429: warning: No description found for parameter 'type'
fs/jbd2/transaction.c:429: warning: No description found for parameter 'line_no'
fs/jbd2/transaction.c:505: warning: No description found for parameter 'type'
fs/jbd2/transaction.c:505: warning: No description found for parameter 'line_no'
fs/jbd2/transaction.c:635: warning: No description found for parameter 'gfp_mask'
vim +/write_op +1438 fs/jbd2/journal.c
24bcc89c Jan Kara 2012-03-13 1422 WARN_ON(!sb->s_sequence);
f7f4bccb Mingming Cao 2006-10-11 1423 journal->j_flags &= ~JBD2_FLUSHED;
24bcc89c Jan Kara 2012-03-13 1424 write_unlock(&journal->j_state_lock);
6f6a6fda Joseph Qi 2015-06-15 1425
6f6a6fda Joseph Qi 2015-06-15 1426 out:
6f6a6fda Joseph Qi 2015-06-15 1427 return ret;
24bcc89c Jan Kara 2012-03-13 1428 }
24bcc89c Jan Kara 2012-03-13 1429
24bcc89c Jan Kara 2012-03-13 1430 /**
24bcc89c Jan Kara 2012-03-13 1431 * jbd2_mark_journal_empty() - Mark on disk journal as empty.
24bcc89c Jan Kara 2012-03-13 1432 * @journal: The journal to update.
24bcc89c Jan Kara 2012-03-13 1433 *
24bcc89c Jan Kara 2012-03-13 1434 * Update a journal's dynamic superblock fields to show that journal is empty.
24bcc89c Jan Kara 2012-03-13 1435 * Write updated superblock to disk waiting for IO to complete.
24bcc89c Jan Kara 2012-03-13 1436 */
b16feb49 OGAWA Hirofumi 2016-02-25 1437 static void jbd2_mark_journal_empty(journal_t *journal, int write_op)
24bcc89c Jan Kara 2012-03-13 @1438 {
24bcc89c Jan Kara 2012-03-13 1439 journal_superblock_t *sb = journal->j_superblock;
24bcc89c Jan Kara 2012-03-13 1440
a78bb11d Jan Kara 2012-03-13 1441 BUG_ON(!mutex_is_locked(&journal->j_checkpoint_mutex));
24bcc89c Jan Kara 2012-03-13 1442 read_lock(&journal->j_state_lock);
eeecef0a Eric Sandeen 2012-08-18 1443 /* Is it already empty? */
eeecef0a Eric Sandeen 2012-08-18 1444 if (sb->s_start == 0) {
eeecef0a Eric Sandeen 2012-08-18 1445 read_unlock(&journal->j_state_lock);
eeecef0a Eric Sandeen 2012-08-18 1446 return;
:::::: The code at line 1438 was first introduced by commit
:::::: 24bcc89c7e7c64982e6192b4952a0a92379fc341 jbd2: split updating of journal superblock and marking journal empty
:::::: TO: Jan Kara <jack@suse.cz>
:::::: CC: Theodore Ts'o <tytso@mit.edu>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 6229 bytes --]
next prev parent reply other threads:[~2016-02-25 13:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 11:28 [PATCH] ext4/jbd2: Fix jbd2_journal_destory() for umount path OGAWA Hirofumi
2016-02-25 13:11 ` kbuild test robot [this message]
2016-03-10 4:59 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201602252133.1j77g0Iw%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=kbuild-all@01.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).