From: Theodore Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 6/6] debugfs: update to handle newer inode fields
Date: Sun, 6 Mar 2016 19:54:44 -0500 [thread overview]
Message-ID: <20160307005444.GF30238@thunk.org> (raw)
In-Reply-To: <1457224716-72388-6-git-send-email-adilger@dilger.ca>
On Sat, Mar 05, 2016 at 05:38:36PM -0700, Andreas Dilger wrote:
> Remove the printing of fragment fields that are HURD only, and
> instead print the i_checksum_lo and i_checksum_hi fields.
>
> Allow setting newer fields in extra inode space with modify_inode.
>
> Add inode_includes() macro to simplify checking for fields in the
> large inode, rather than hard-coding field offsets in the code.
>
> Fix corresponding tests for newly added Checksum field.
>
> Signed-off-by: Andreas Dilger <adilger@dilger.ca>
This patch changes way too much at one time, and won't apply given
other changes that have been made by Li Xi and myself.
I wouldn't bother adding stuff to modify_inode; that's an old
interface that is extremely awkward to use, and is there because there
might be a few people who might like it. These days, set_inode_field
is the new interface that is much more flexible and easier to use.
Li Xi has added inode_includes into lib/ext2fs/ext2_fs.h. I will
probably rename it to ext2fs_inode_includes() just to avoid namespace
collision problems.
Cheers,
- Ted
next prev parent reply other threads:[~2016-03-07 0:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-06 0:38 [PATCH 1/6] blkid: fix ZFS device detection Andreas Dilger
2016-03-06 0:38 ` [PATCH 2/6] debugfs: improve dump_mmp handling Andreas Dilger
2016-03-06 23:11 ` Theodore Ts'o
2016-03-06 0:38 ` [PATCH 3/6] misc: add missing declarations on maint Andreas Dilger
2016-03-06 23:12 ` Theodore Ts'o
2016-03-06 0:38 ` [PATCH 4/6] lsattr: treat inode generation as an unsigned int Andreas Dilger
2016-03-06 23:13 ` Theodore Ts'o
2016-03-06 0:38 ` [PATCH 5/6] findsuper: improve output if s_mkfs_time unset Andreas Dilger
2016-03-06 23:16 ` Theodore Ts'o
2016-03-06 0:38 ` [PATCH 6/6] debugfs: update to handle newer inode fields Andreas Dilger
2016-03-07 0:54 ` Theodore Ts'o [this message]
2016-03-06 23:10 ` [PATCH 1/6] blkid: fix ZFS device detection Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160307005444.GF30238@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).