[PATCH] fix compile error while opening the macro DOUBLE_CHECK

[PATCH] fix compile error while opening the macro DOUBLE_CHECK

[zhangaihua1]

From: Aihua Zhang <zhangaihua1@huawei.com>

the error is:
    fs/ext4/mballoc.c:475:43: error: 'struct ext4_group_info' has
no member named 'bb_bitmap'.
    so, the definition of macro DOUBLE_CHECK should before
'struct ext4_group_info', I fixed it, and I moved the macro
AGGRESSIVE_CHECK together, because I think they shoule be together.

Signed-off-by: Aihua Zhang <zhangaihua1@huawei.com>
---
 fs/ext4/ext4.h    |   12 ++++++++++++
 fs/ext4/mballoc.h |   12 ------------
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 750063f..04a3732 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -41,6 +41,18 @@
  */
 
 /*
+ * with AGGRESSIVE_CHECK allocator runs consistency checks over
+ * structures. these checks slow things down a lot
+ */
+#define AGGRESSIVE_CHECK__
+
+/*
+ * with DOUBLE_CHECK defined mballoc creates persistent in-core
+ * bitmaps, maintains and uses them to check for double allocations
+ */
+#define DOUBLE_CHECK__
+
+/*
  * Define EXT4FS_DEBUG to produce debug messages
  */
 #undef EXT4FS_DEBUG
diff --git a/fs/ext4/mballoc.h b/fs/ext4/mballoc.h
index d634e18..3ef1df6 100644
--- a/fs/ext4/mballoc.h
+++ b/fs/ext4/mballoc.h
@@ -23,18 +23,6 @@
 #include "ext4.h"
 
 /*
- * with AGGRESSIVE_CHECK allocator runs consistency checks over
- * structures. these checks slow things down a lot
- */
-#define AGGRESSIVE_CHECK__
-
-/*
- * with DOUBLE_CHECK defined mballoc creates persistent in-core
- * bitmaps, maintains and uses them to check for double allocations
- */
-#define DOUBLE_CHECK__

Re: [PATCH] fix compile error while opening the macro DOUBLE_CHECK

[Theodore Ts'o]

On Tue, Dec 01, 2015 at 04:58:29PM +0800, zhangaihua1@huawei.com wrote:
> From: Aihua Zhang <zhangaihua1@huawei.com>
> 
> the error is:
>     fs/ext4/mballoc.c:475:43: error: 'struct ext4_group_info' has
> no member named 'bb_bitmap'.
>     so, the definition of macro DOUBLE_CHECK should before
> 'struct ext4_group_info', I fixed it, and I moved the macro
> AGGRESSIVE_CHECK together, because I think they shoule be together.
> 
> Signed-off-by: Aihua Zhang <zhangaihua1@huawei.com>

Applied, thanks.  Apologies for the delay.

							- Ted

[PATCH] fix compile error while opening the macro DOUBLE_CHECK

[zhangaihua1]

From: Aihua Zhang <zhangaihua1@huawei.com>

the error is:
    fs/ext4/mballoc.c:475:43: error: 'struct ext4_group_info' has
no member named 'bb_bitmap'
    the definition of macro should before 'struct ext4_group_info'

Signed-off-by: Aihua Zhang <zhangaihua1@huawei.com>
---
 fs/ext4/ext4.h    |   12 ++++++++++++
 fs/ext4/mballoc.h |   12 ------------
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 750063f..04a3732 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -41,6 +41,18 @@
  */
 
 /*
+ * with AGGRESSIVE_CHECK allocator runs consistency checks over
+ * structures. these checks slow things down a lot
+ */
+#define AGGRESSIVE_CHECK__
+
+/*
+ * with DOUBLE_CHECK defined mballoc creates persistent in-core
+ * bitmaps, maintains and uses them to check for double allocations
+ */
+#define DOUBLE_CHECK__
+
+/*
  * Define EXT4FS_DEBUG to produce debug messages
  */
 #undef EXT4FS_DEBUG
diff --git a/fs/ext4/mballoc.h b/fs/ext4/mballoc.h
index d634e18..3ef1df6 100644
--- a/fs/ext4/mballoc.h
+++ b/fs/ext4/mballoc.h
@@ -23,18 +23,6 @@
 #include "ext4.h"
 
 /*
- * with AGGRESSIVE_CHECK allocator runs consistency checks over
- * structures. these checks slow things down a lot
- */
-#define AGGRESSIVE_CHECK__
-
-/*
- * with DOUBLE_CHECK defined mballoc creates persistent in-core
- * bitmaps, maintains and uses them to check for double allocations
- */
-#define DOUBLE_CHECK__
-
-/*
  */
 #ifdef CONFIG_EXT4_DEBUG
 extern ushort ext4_mballoc_debug;
-- 
1.7.1

[PATCH] fix compile error while opening the macro DOUBLE_CHECK

[zhangaihua1]

From: Aihua Zhang <zhangaihua1@huawei.com>

the error is:
    fs/ext4/mballoc.c:475:43: error: 'struct ext4_group_info' has
no member named 'bb_bitmap'
    the definition of macro should before 'struct ext4_group_info'

Signed-off-by: Aihua Zhang <zhangaihua1@huawei.com>
---
 fs/ext4/ext4.h    |   12 ++++++++++++
 fs/ext4/mballoc.h |   12 ------------
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 750063f..e743955 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -41,6 +41,18 @@
  */
 
 /*
+ * with AGGRESSIVE_CHECK allocator runs consistency checks over
+ * structures. these checks slow things down a lot
+ * /
+#define AGGRESSIVE_CHECK__
+
+/*
+ * with DOUBLE_CHECK defined mballoc creates persistent in-core
+ * bitmaps, maintains and uses them to check for double allocations
+ * /
+#define DOUBLE_CHECK__
+
+/*
  * Define EXT4FS_DEBUG to produce debug messages
  */
 #undef EXT4FS_DEBUG
diff --git a/fs/ext4/mballoc.h b/fs/ext4/mballoc.h
index d634e18..3ef1df6 100644
--- a/fs/ext4/mballoc.h
+++ b/fs/ext4/mballoc.h
@@ -23,18 +23,6 @@
 #include "ext4.h"
 
 /*
- * with AGGRESSIVE_CHECK allocator runs consistency checks over
- * structures. these checks slow things down a lot
- */
-#define AGGRESSIVE_CHECK__
-
-/*
- * with DOUBLE_CHECK defined mballoc creates persistent in-core
- * bitmaps, maintains and uses them to check for double allocations
- */
-#define DOUBLE_CHECK__
-
-/*
  */
 #ifdef CONFIG_EXT4_DEBUG
 extern ushort ext4_mballoc_debug;
-- 
1.7.1

Re: [PATCH] fix compile error while opening the macro DOUBLE_CHECK

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1736 bytes --]

Hi Aihua,

[auto build test WARNING on: v4.4-rc1]
[also build test WARNING on: next-20151117]

url:    https://github.com/0day-ci/linux/commits/zhangaihua1-huawei-com/fix-compile-error-while-opening-the-macro-DOUBLE_CHECK/20151117-110904
config: parisc-c3000_defconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=parisc 

All warnings (new ones prefixed by >>):

   In file included from fs/ext4/ext4_jbd2.h:20:0,
                    from fs/ext4/extents.c:43:
>> fs/ext4/ext4.h:49:1: warning: "/*" within comment [-Wcomment]
    /*
    ^
   fs/ext4/ext4.h:55:1: warning: "/*" within comment [-Wcomment]
    /*
    ^

vim +49 fs/ext4/ext4.h

    33	#include <crypto/hash.h>
    34	#include <linux/falloc.h>
    35	#ifdef __KERNEL__
    36	#include <linux/compat.h>
    37	#endif
    38	
    39	/*
    40	 * The fourth extended filesystem constants/structures
    41	 */
    42	
    43	/*
    44	 * with AGGRESSIVE_CHECK allocator runs consistency checks over
    45	 * structures. these checks slow things down a lot
    46	 * /
    47	#define AGGRESSIVE_CHECK__
    48	
  > 49	/*
    50	 * with DOUBLE_CHECK defined mballoc creates persistent in-core
    51	 * bitmaps, maintains and uses them to check for double allocations
    52	 * /
    53	#define DOUBLE_CHECK__
    54	
    55	/*
    56	 * Define EXT4FS_DEBUG to produce debug messages
    57	 */

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 13631 bytes --]

Re: [PATCH] fix compile error while opening the macro DOUBLE_CHECK

[Greg KH]

On Tue, Nov 17, 2015 at 11:04:03AM +0800, zhangaihua1@huawei.com wrote:
> From: Aihua Zhang <zhangaihua1@huawei.com>
> 
> the error is:
>     fs/ext4/mballoc.c:475:43: error: 'struct ext4_group_info' has
> no member named 'bb_bitmap'
>     the definition of macro should before 'struct ext4_group_info'
> 
> Signed-off-by: Aihua Zhang <zhangaihua1@huawei.com>
> ---
>  fs/ext4/ext4.h    |   12 ++++++++++++
>  fs/ext4/mballoc.h |   12 ------------
>  2 files changed, 12 insertions(+), 12 deletions(-)

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

</formletter>

Re: [PATCH] fix compile error while opening the macro DOUBLE_CHECK

[Zhang AiHua]

Hi,

     I want to submit the patch to mainline, I feel so ashamed for disturbing you,
you can ignore it....  I have written wrong email.
     Later, when I need, I will read Documentation/stable_kernel_rules.txt first,
thank you anyway.

Regards, AiHua.


在 2015/11/17 12:03, Greg KH 写道:
> On Tue, Nov 17, 2015 at 11:04:03AM +0800, zhangaihua1@huawei.com wrote:
>> From: Aihua Zhang <zhangaihua1@huawei.com>
>>
>> the error is:
>>      fs/ext4/mballoc.c:475:43: error: 'struct ext4_group_info' has
>> no member named 'bb_bitmap'
>>      the definition of macro should before 'struct ext4_group_info'
>>
>> Signed-off-by: Aihua Zhang <zhangaihua1@huawei.com>
>> ---
>>   fs/ext4/ext4.h    |   12 ++++++++++++
>>   fs/ext4/mballoc.h |   12 ------------
>>   2 files changed, 12 insertions(+), 12 deletions(-)
>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
> for how to do this properly.
>
> </formletter>
>
> .
>