linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/2] generic: test I/O on dm error device
Date: Tue, 15 Mar 2016 13:46:16 +1100	[thread overview]
Message-ID: <20160315024616.GC30721@dastard> (raw)
In-Reply-To: <1457710822-30532-2-git-send-email-eguan@redhat.com>

On Fri, Mar 11, 2016 at 11:40:22PM +0800, Eryu Guan wrote:
> This is a test that performs simple I/O on dm error device, which
> returns EIO on all I/O request.
> 
> This is motivated by an ext4 bug that crashes kernel on error path when
> trying to update atime. Following kernel patch should fix the issue
> 
>   ext4: fix NULL pointer dereference in ext4_mark_inode_dirty()

Why does this test require the loop device? Why can't you just
unmount the filesystem, run 'blkdev --flushbufs <dev>' to ensure
there are no cached buffers/pages on the block device, then mount
it again?

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

  reply	other threads:[~2016-03-15  2:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-11 15:40 [PATCH 1/2] common: make _dmerror_init accept device and mount point as param Eryu Guan
2016-03-11 15:40 ` [PATCH 2/2] generic: test I/O on dm error device Eryu Guan
2016-03-15  2:46   ` Dave Chinner [this message]
2016-03-15  8:02     ` Eryu Guan
2016-03-15  8:12   ` [PATCH v2] " Eryu Guan
2016-03-23  2:53     ` Dave Chinner
2016-03-23  3:25       ` Eryu Guan
2016-03-23  4:14         ` Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160315024616.GC30721@dastard \
    --to=david@fromorbit.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).