From: Eryu Guan <eguan@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: fstests@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH v2] generic: test I/O on dm error device
Date: Wed, 23 Mar 2016 11:25:31 +0800 [thread overview]
Message-ID: <20160323032531.GN11419@eguan.usersys.redhat.com> (raw)
In-Reply-To: <20160323025327.GZ11812@dastard>
On Wed, Mar 23, 2016 at 01:53:27PM +1100, Dave Chinner wrote:
> On Tue, Mar 15, 2016 at 04:12:14PM +0800, Eryu Guan wrote:
> > This is a test that performs simple I/O on dm error device, which
> > returns EIO on all I/O request.
> >
> > This is motivated by an ext4 bug that crashes kernel on error path when
> > trying to update atime. Following kernel patch should fix the issue
> >
> > ext4: fix NULL pointer dereference in ext4_mark_inode_dirty()
> >
> > Signed-off-by: Eryu Guan <eguan@redhat.com>
> > ---
>
> Fails with:
>
> @@ -1,2 +1,6 @@
> QA output created by 338
> Silence is golden
> +specified blocksize 1024 is less than device physical sector size 4096
> +switching to logical sector size 512
> +mkfs.xfs: /dev/mapper/error-test appears to contain an existing filesystem (xfs).
> +mkfs.xfs: Use the -f option to force overwrite.
>
> And then it failed to clean up properly and caused all sorts of
> subsequent problems.
Test passed for me, seems it has something to do with the "physical
sector size 4096" device. I'll look into it. Thanks for the review!
Eryu
next prev parent reply other threads:[~2016-03-23 3:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 15:40 [PATCH 1/2] common: make _dmerror_init accept device and mount point as param Eryu Guan
2016-03-11 15:40 ` [PATCH 2/2] generic: test I/O on dm error device Eryu Guan
2016-03-15 2:46 ` Dave Chinner
2016-03-15 8:02 ` Eryu Guan
2016-03-15 8:12 ` [PATCH v2] " Eryu Guan
2016-03-23 2:53 ` Dave Chinner
2016-03-23 3:25 ` Eryu Guan [this message]
2016-03-23 4:14 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160323032531.GN11419@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).