From: "hch@infradead.org" <hch@infradead.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "Verma, Vishal L" <vishal.l.verma@intel.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"jack@suse.cz" <jack@suse.cz>, "axboe@fb.com" <axboe@fb.com>,
"linux-nvdimm@ml01.01.org" <linux-nvdimm@ml01.01.org>,
"xfs@oss.sgi.com" <xfs@oss.sgi.com>,
"hch@infradead.org" <hch@infradead.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"ross.zwisler@linux.intel.com" <ross.zwisler@linux.intel.com>,
"Wilcox, Matthew R" <matthew.r.wilcox@intel.com>
Subject: Re: [PATCH 5/5] dax: handle media errors in dax_do_io
Date: Sat, 26 Mar 2016 09:53:59 -0700 [thread overview]
Message-ID: <20160326165359.GA11387@infradead.org> (raw)
In-Reply-To: <CAPcyv4jFPYYP=eL72V6MmW2fcXFP3PfQfcO+zYV4NN7rdu1ksg@mail.gmail.com>
On Fri, Mar 25, 2016 at 02:42:37PM -0700, Dan Williams wrote:
> That's their prerogative otherwise you are precluding an alternate
> handling of a dax_do_io() failure. Maybe a fs or upper layer can
> recover in a different manner than re-submit the I/O to the
> __blockdev_direct_IO path.
Let's keep the interface separate because they are, well separate.
There is a reason direct I/O falls back to buffered I/O by returning
and error if it can't handle it instead of handling all the magic.
I also really want to get rid of get_block as soon as possible for
DAX and direct I/O. For DAX that should actually be possible
really quickly, while direct I/O might take some time and will
be have to be gradual. So tighter integration of the two interface is
not just bad design, but actively harmful at this point in time.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-03-26 16:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 23:17 [PATCH 0/5] dax: handling of media errors Vishal Verma
2016-03-24 23:17 ` [PATCH 1/5] block, dax: pass blk_dax_ctl through to drivers Vishal Verma
2016-03-24 23:17 ` [PATCH 2/5] dax: fallback from pmd to pte on error Vishal Verma
2016-03-24 23:17 ` [PATCH 3/5] dax: enable dax in the presence of known media errors (badblocks) Vishal Verma
2016-03-24 23:23 ` Verma, Vishal L
2016-03-24 23:17 ` [PATCH 4/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors Vishal Verma
2016-03-25 10:44 ` Christoph Hellwig
2016-03-25 21:01 ` Verma, Vishal L
2016-03-25 18:47 ` Dan Williams
2016-03-25 21:03 ` Verma, Vishal L
2016-03-25 21:20 ` Dan Williams
2016-03-28 20:01 ` Verma, Vishal L
2016-03-28 23:34 ` Dan Williams
2016-03-29 18:57 ` Verma, Vishal L
2016-03-29 19:37 ` Dan Williams
2016-03-30 7:49 ` Jan Kara
2016-04-01 19:17 ` Verma, Vishal L
2016-04-04 12:09 ` Jan Kara
2016-03-24 23:17 ` [PATCH 5/5] dax: handle media errors in dax_do_io Vishal Verma
2016-03-25 10:45 ` Christoph Hellwig
2016-03-25 20:59 ` Verma, Vishal L
2016-03-25 21:42 ` Dan Williams
2016-03-25 22:36 ` Verma, Vishal L
2016-03-26 16:53 ` hch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160326165359.GA11387@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@fb.com \
--cc=dan.j.williams@intel.com \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=matthew.r.wilcox@intel.com \
--cc=ross.zwisler@linux.intel.com \
--cc=viro@zeniv.linux.org.uk \
--cc=vishal.l.verma@intel.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).