From: Jan Kara <jack@suse.cz>
To: Theodore Ts'o <tytso@mit.edu>
Cc: jack@suse.cz, linux-ext4@vger.kernel.org
Subject: Re: GETNEXTQUOTA causes kernel crash if quota not enabled
Date: Tue, 29 Mar 2016 13:36:33 +0200 [thread overview]
Message-ID: <20160329113633.GD12993@quack.suse.cz> (raw)
In-Reply-To: <20160328044339.GA15808@thunk.org>
On Mon 28-03-16 00:43:39, Ted Tso wrote:
> Hi Jan, this looks like a recent change that just landed in the quota
> tree. The crash is in dquot_get_next_id() because
> sb_dqopt(sb)->ops[0] is NULL.
>
> This looks like it was introduced in a fairly recent commit:
> be6257b251ce ("quota: Add support for ->get_nextdqblk() for VFS
> quota").
>
> Please see reproduction below. It can also be easily reproduced using
> "kvm-xfstests -c encrypt generic/244")
Thanks for report! Obviously we are missing a test whether quota is
actually enabled for the filesystem (the test generic/244 seems to be
somewhat buggy for VFS quota based filesystems). It was not written yet
when I was testing my changes and it never occured to me to run
Q_GENTEXTQUOTA against a filesystem with quotas disabled... I'll fix it up.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2016-03-29 11:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-28 4:43 GETNEXTQUOTA causes kernel crash if quota not enabled Theodore Ts'o
2016-03-29 11:36 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160329113633.GD12993@quack.suse.cz \
--to=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox