From: Al Viro <viro@ZenIV.linux.org.uk>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
dhowells@redhat.com,
Linux Filesystem Development List <linux-fsdevel@vger.kernel.org>,
jaegeuk@kernel.org
Subject: Re: [PATCH 0/5] Miklos's vfs/nfs/ext4 patches in the ext4.git tree
Date: Tue, 29 Mar 2016 20:58:45 +0100 [thread overview]
Message-ID: <20160329195844.GW17997@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1459026600-9232-1-git-send-email-tytso@mit.edu>
On Sat, Mar 26, 2016 at 05:09:55PM -0400, Theodore Ts'o wrote:
> I have the following patches in the ext4.git tree which I plan to push
> to Linus as bug fixes during this development cycles. Al, are you
> happy with Miklos's v2 version of "fs: add file_dentrY()" patch?
I'm not really happy, but I guess we'll have to live with that approach.
I would still like to point out that *any* use of file_dentry() (or
file->f_path.dentry, for that matter) is a serious red flag - odds are,
the code using it is broken, possibly by design.
I still don't understand the locking in ext4 crypto, and I'm not at all
convinced that it is correct ;-/ OTOH, there are filesystems where we
really need dentry and (hopefully) treat it sanely enough, so consider
that helper and method ACKed. I can take it via vfs.git, or leave it
to ext4.git, or do some combination thereof (e.g. the infrastructure
goes into never-rebased branch in vfs.git, with ext4/btrfs/nfs merging
from it). Up to you...
Al, still bloody unhappy about the whole pile of worms...
prev parent reply other threads:[~2016-03-29 19:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-26 21:09 [PATCH 0/5] Miklos's vfs/nfs/ext4 patches in the ext4.git tree Theodore Ts'o
2016-03-26 21:09 ` [PATCH 1/5] fs: add file_dentry() Theodore Ts'o
2016-03-26 21:09 ` [PATCH 2/5] nfs: use file_dentry() Theodore Ts'o
2016-03-26 21:09 ` [PATCH 3/5] ext4: use dget_parent() in ext4_file_open() Theodore Ts'o
2016-03-26 21:09 ` [PATCH 4/5] ext4: use file_dentry() Theodore Ts'o
2016-03-26 21:10 ` [PATCH 5/5] ext4 crypto: use dget_parent() in ext4_d_revalidate() Theodore Ts'o
2016-03-27 8:02 ` Sedat Dilek
2016-03-27 18:16 ` Theodore Ts'o
2016-03-27 8:06 ` [PATCH 0/5] Miklos's vfs/nfs/ext4 patches in the ext4.git tree Sedat Dilek
2016-03-27 18:15 ` Theodore Ts'o
2016-03-27 19:31 ` Sedat Dilek
2016-03-28 12:36 ` Theodore Ts'o
2016-03-27 22:51 ` Sedat Dilek
2016-03-28 14:02 ` Chris Mason
2016-03-29 17:15 ` Theodore Ts'o
2016-03-29 20:12 ` Chris Mason
2016-03-29 19:58 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160329195844.GW17997@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=dhowells@redhat.com \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).