* Reporting project quota usage? @ 2016-03-16 5:29 Theodore Ts'o 2016-03-16 21:49 ` Andreas Dilger 2016-03-17 1:47 ` Li Xi 0 siblings, 2 replies; 10+ messages in thread From: Theodore Ts'o @ 2016-03-16 5:29 UTC (permalink / raw) To: pkuelelixi; +Cc: jack, adilger, linux-ext4 Am I missing something, or do we currently don't have a way to report project quota usage with ext4? The support doesn't appear to be in quota tools, and xfs_quota doesn't work without changes because it only tries to operate on XFS file systems. Thanks, - Ted ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Reporting project quota usage? 2016-03-16 5:29 Reporting project quota usage? Theodore Ts'o @ 2016-03-16 21:49 ` Andreas Dilger 2016-03-17 0:48 ` Theodore Ts'o 2016-03-17 1:47 ` Li Xi 1 sibling, 1 reply; 10+ messages in thread From: Andreas Dilger @ 2016-03-16 21:49 UTC (permalink / raw) To: Theodore Ts'o; +Cc: Li Xi, Jan Kara, Dave Chinner, linux-ext4 [-- Attachment #1: Type: text/plain, Size: 683 bytes --] On Mar 15, 2016, at 11:29 PM, Theodore Ts'o <tytso@mit.edu> wrote: > > Am I missing something, or do we currently don't have a way to report > project quota usage with ext4? The support doesn't appear to be in > quota tools, and xfs_quota doesn't work without changes because it > only tries to operate on XFS file systems. At one time I thought Dave was going to patch xfs_quota to try the quota ioctls for "foreign" filesystems like ext4 that supported them, but I'm not sure if that patch was landed, nor whether it has been released. On the opposite front, Jan was updating the generic quota tools to support the XFS ioctls that project quota is using? Cheers, Andreas [-- Attachment #2: Message signed with OpenPGP using GPGMail --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Reporting project quota usage? 2016-03-16 21:49 ` Andreas Dilger @ 2016-03-17 0:48 ` Theodore Ts'o 2016-03-17 1:31 ` Dave Chinner 2016-03-18 9:40 ` Jan Kara 0 siblings, 2 replies; 10+ messages in thread From: Theodore Ts'o @ 2016-03-17 0:48 UTC (permalink / raw) To: Andreas Dilger; +Cc: Li Xi, Jan Kara, Dave Chinner, linux-ext4 On Wed, Mar 16, 2016 at 03:49:31PM -0600, Andreas Dilger wrote: > > At one time I thought Dave was going to patch xfs_quota to try the quota > ioctls for "foreign" filesystems like ext4 that supported them, but I'm > not sure if that patch was landed, nor whether it has been released. > > On the opposite front, Jan was updating the generic quota tools to support > the XFS ioctls that project quota is using? It's quite possible I'm missing something, but it doesn't look like either has landed. I've hacked xfs_quota (not anything that I would want to submit for merging) so I can report usage project quota stats, and to be able to set hard and soft limits. But I was trying to figure out what we should be telling users who wanted to use Project Quota, but I'm pretty sure "pull down xfsprogs sources, and apply this hacky patch[1], and then when you use the tooll ignore a whole bunch of spurious warnings" is the right way to go. :-) I am also curious how Li Xi was testing the patches he sent me. - Ted [1] diff --git a/libxcmd/paths.c b/libxcmd/paths.c index 5c65737..6c69a35 100644 --- a/libxcmd/paths.c +++ b/libxcmd/paths.c @@ -301,8 +301,8 @@ fs_table_initialise_mounts( return errno; while ((mnt = getmntent(mtp)) != NULL) { - if (strcmp(mnt->mnt_type, "xfs") != 0) - continue; +// if (strcmp(mnt->mnt_type, "xfs") != 0) +// continue; if (!realpath(mnt->mnt_dir, rmnt_dir)) continue; if (!realpath(mnt->mnt_fsname, rmnt_fsname)) ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: Reporting project quota usage? 2016-03-17 0:48 ` Theodore Ts'o @ 2016-03-17 1:31 ` Dave Chinner 2016-03-18 9:40 ` Jan Kara 1 sibling, 0 replies; 10+ messages in thread From: Dave Chinner @ 2016-03-17 1:31 UTC (permalink / raw) To: Theodore Ts'o; +Cc: Andreas Dilger, Li Xi, Jan Kara, linux-ext4 On Wed, Mar 16, 2016 at 08:48:47PM -0400, Theodore Ts'o wrote: > On Wed, Mar 16, 2016 at 03:49:31PM -0600, Andreas Dilger wrote: > > > > At one time I thought Dave was going to patch xfs_quota to try the quota > > ioctls for "foreign" filesystems like ext4 that supported them, but I'm > > not sure if that patch was landed, nor whether it has been released. > > > > On the opposite front, Jan was updating the generic quota tools to support > > the XFS ioctls that project quota is using? > > It's quite possible I'm missing something, but it doesn't look like > either has landed. I've hacked xfs_quota (not anything that I would > want to submit for merging) I posted a patch to do it, but I haven't had a chance to fix the problems Eric noticed because other stuff happened. You're welcome to fix it up and repost it: http://oss.sgi.com/archives/xfs/2016-02/msg00109.html Cheers, Dave. -- Dave Chinner david@fromorbit.com ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Reporting project quota usage? 2016-03-17 0:48 ` Theodore Ts'o 2016-03-17 1:31 ` Dave Chinner @ 2016-03-18 9:40 ` Jan Kara 1 sibling, 0 replies; 10+ messages in thread From: Jan Kara @ 2016-03-18 9:40 UTC (permalink / raw) To: Theodore Ts'o Cc: Andreas Dilger, Li Xi, Jan Kara, Dave Chinner, linux-ext4 On Wed 16-03-16 20:48:47, Ted Tso wrote: > On Wed, Mar 16, 2016 at 03:49:31PM -0600, Andreas Dilger wrote: > > > > At one time I thought Dave was going to patch xfs_quota to try the quota > > ioctls for "foreign" filesystems like ext4 that supported them, but I'm > > not sure if that patch was landed, nor whether it has been released. > > > > On the opposite front, Jan was updating the generic quota tools to support > > the XFS ioctls that project quota is using? > > It's quite possible I'm missing something, but it doesn't look like > either has landed. I've hacked xfs_quota (not anything that I would > want to submit for merging) so I can report usage project quota stats, > and to be able to set hard and soft limits. But I was trying to > figure out what we should be telling users who wanted to use Project > Quota, but I'm pretty sure "pull down xfsprogs sources, and apply this > hacky patch[1], and then when you use the tooll ignore a whole bunch > of spurious warnings" is the right way to go. :-) > > I am also curious how Li Xi was testing the patches he sent me. As Li Xi mentioned, he has a patch for quota-tools which implements the project quota support but it needs some cleanup (you can check my reply to email "[PATCH] Add project quota support" - it didn't go to any list but you were CCed). Li Xi, do you have any idea when you can get to it? Honza -- Jan Kara <jack@suse.com> SUSE Labs, CR ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Reporting project quota usage? 2016-03-16 5:29 Reporting project quota usage? Theodore Ts'o 2016-03-16 21:49 ` Andreas Dilger @ 2016-03-17 1:47 ` Li Xi 2016-03-22 14:58 ` Jan Kara 1 sibling, 1 reply; 10+ messages in thread From: Li Xi @ 2016-03-17 1:47 UTC (permalink / raw) To: Theodore Ts'o; +Cc: Jan Kara, Andreas Dilger, Ext4 Developers List Hi, I sent a patch of quota tool to Jan Kara ccing you. With that patch, project quota of ext4 can be reported. However, that patch needs a lot of improvement. That patch can be found here too: https://github.com/ddn-lixi/project_quota_ext4_utils/blob/master/quota-tools.git/patches/project_quota_support_for_quota-tools.patch Regards, Li Xi On Wed, Mar 16, 2016 at 1:29 PM, Theodore Ts'o <tytso@mit.edu> wrote: > Am I missing something, or do we currently don't have a way to report > project quota usage with ext4? The support doesn't appear to be in > quota tools, and xfs_quota doesn't work without changes because it > only tries to operate on XFS file systems. > > Thanks, > > - Ted ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Reporting project quota usage? 2016-03-17 1:47 ` Li Xi @ 2016-03-22 14:58 ` Jan Kara 2016-03-30 9:25 ` Jan Kara 0 siblings, 1 reply; 10+ messages in thread From: Jan Kara @ 2016-03-22 14:58 UTC (permalink / raw) To: Li Xi; +Cc: Theodore Ts'o, Jan Kara, Andreas Dilger, Ext4 Developers List Hi, On Thu 17-03-16 09:47:44, Li Xi wrote: > I sent a patch of quota tool to Jan Kara ccing you. With that patch, > project quota > of ext4 can be reported. However, that patch needs a lot of improvement. > > That patch can be found here too: > > https://github.com/ddn-lixi/project_quota_ext4_utils/blob/master/quota-tools.git/patches/project_quota_support_for_quota-tools.patch Li Xi, if I find time to massage the patch into usable form, can I add your Signed-off-by so that I can commit it in quota-tools repository? Honza > On Wed, Mar 16, 2016 at 1:29 PM, Theodore Ts'o <tytso@mit.edu> wrote: > > Am I missing something, or do we currently don't have a way to report > > project quota usage with ext4? The support doesn't appear to be in > > quota tools, and xfs_quota doesn't work without changes because it > > only tries to operate on XFS file systems. > > > > Thanks, > > > > - Ted -- Jan Kara <jack@suse.com> SUSE Labs, CR ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Reporting project quota usage? 2016-03-22 14:58 ` Jan Kara @ 2016-03-30 9:25 ` Jan Kara 2016-03-31 2:55 ` Li Xi 0 siblings, 1 reply; 10+ messages in thread From: Jan Kara @ 2016-03-30 9:25 UTC (permalink / raw) To: Li Xi; +Cc: Theodore Ts'o, Jan Kara, Andreas Dilger, Ext4 Developers List On Tue 22-03-16 15:58:46, Jan Kara wrote: > Hi, > > On Thu 17-03-16 09:47:44, Li Xi wrote: > > I sent a patch of quota tool to Jan Kara ccing you. With that patch, > > project quota > > of ext4 can be reported. However, that patch needs a lot of improvement. > > > > That patch can be found here too: > > > > https://github.com/ddn-lixi/project_quota_ext4_utils/blob/master/quota-tools.git/patches/project_quota_support_for_quota-tools.patch > > Li Xi, if I find time to massage the patch into usable form, can I add your > Signed-off-by so that I can commit it in quota-tools repository? Ping? Without your Signed-off-by tag I cannot really add your code into quota-tools repository... Honza -- Jan Kara <jack@suse.com> SUSE Labs, CR ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Reporting project quota usage? 2016-03-30 9:25 ` Jan Kara @ 2016-03-31 2:55 ` Li Xi 2016-03-31 8:47 ` Jan Kara 0 siblings, 1 reply; 10+ messages in thread From: Li Xi @ 2016-03-31 2:55 UTC (permalink / raw) To: Jan Kara; +Cc: Theodore Ts'o, Andreas Dilger, Ext4 Developers List Hi Jan Kara, Sorry for delay. Please feel free to add "Signed-off-by: Li Xi <lixi@ddn.com>". Regards, Li Xi On Wed, Mar 30, 2016 at 5:25 PM, Jan Kara <jack@suse.cz> wrote: > On Tue 22-03-16 15:58:46, Jan Kara wrote: >> Hi, >> >> On Thu 17-03-16 09:47:44, Li Xi wrote: >> > I sent a patch of quota tool to Jan Kara ccing you. With that patch, >> > project quota >> > of ext4 can be reported. However, that patch needs a lot of improvement. >> > >> > That patch can be found here too: >> > >> > https://github.com/ddn-lixi/project_quota_ext4_utils/blob/master/quota-tools.git/patches/project_quota_support_for_quota-tools.patch >> >> Li Xi, if I find time to massage the patch into usable form, can I add your >> Signed-off-by so that I can commit it in quota-tools repository? > > Ping? Without your Signed-off-by tag I cannot really add your code into > quota-tools repository... > > Honza > -- > Jan Kara <jack@suse.com> > SUSE Labs, CR ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Reporting project quota usage? 2016-03-31 2:55 ` Li Xi @ 2016-03-31 8:47 ` Jan Kara 0 siblings, 0 replies; 10+ messages in thread From: Jan Kara @ 2016-03-31 8:47 UTC (permalink / raw) To: Li Xi; +Cc: Jan Kara, Theodore Ts'o, Andreas Dilger, Ext4 Developers List Hi! On Thu 31-03-16 10:55:51, Li Xi wrote: > Sorry for delay. > > Please feel free to add "Signed-off-by: Li Xi <lixi@ddn.com>". Thanks. I have pushed out patches with project quota support to quota-tools reporsitories. Honza -- Jan Kara <jack@suse.com> SUSE Labs, CR ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-03-31 8:47 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-03-16 5:29 Reporting project quota usage? Theodore Ts'o 2016-03-16 21:49 ` Andreas Dilger 2016-03-17 0:48 ` Theodore Ts'o 2016-03-17 1:31 ` Dave Chinner 2016-03-18 9:40 ` Jan Kara 2016-03-17 1:47 ` Li Xi 2016-03-22 14:58 ` Jan Kara 2016-03-30 9:25 ` Jan Kara 2016-03-31 2:55 ` Li Xi 2016-03-31 8:47 ` Jan Kara
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).