From: Theodore Ts'o <tytso@mit.edu>
To: Daeho Jeong <daeho.jeong@samsung.com>
Cc: "jack@suse.cz" <jack@suse.cz>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH v4 2/3] ext4: fix races between changing inode journal mode and ext4_writepages
Date: Wed, 27 Apr 2016 10:30:32 -0400 [thread overview]
Message-ID: <20160427143032.GG30021@thunk.org> (raw)
In-Reply-To: <1319414639.152111461744250568.JavaMail.weblogic@ep2mlwas01c>
On Wed, Apr 27, 2016 at 08:04:10AM +0000, Daeho Jeong wrote:
> Oops, sorry about causing the regression.
>
> But in the version I worked on, we passed the test case and
> we still pass that. I executed the test case as belows.
>
> kvm-xfstests -c 1k -C 10 generic/231
>
> I am going to retry the test using GCE with the latest kernel version.
Hi, sorry, it looks like I jumped to conclusions too hastily.
I let the tests finish last night and generic/231 is failing around
10-20% of the time prior to your patch series. I just didn't notice it
at first because the failure happened at the very end:
xfstests results 201604270033 - 4.6.0-rc4-ext4
Passed all 1 tests
Passed all 1 tests
Passed all 1 tests
Passed all 1 tests
Passed all 1 tests
Passed all 1 tests
Passed all 1 tests
Passed all 1 tests
Failures: generic/231
Failures: generic/231
With your patches, it remains at about the same level, but when the
tests failed caused me to assume they were the caused by your patches.
xfstests results 201604270044 - 4.6.0-rc4-ext4-00007-g76bee81 (Just before your patches)
Passed all 1 tests
Passed all 1 tests
Passed all 1 tests
Passed all 1 tests
Failures: generic/231
Passed all 1 tests
Passed all 1 tests
Passed all 1 tests
Failures: generic/231
Passed all 1 tests
xfstests results 201604270054 - 4.6.0-rc4-ext4-00008-g31cedaa (Your 1/3 patch)
Passed all 1 tests
Passed all 1 tests
Passed all 1 tests
Failures: generic/231
Passed all 1 tests
Passed all 1 tests
Passed all 1 tests
Passed all 1 tests
Passed all 1 tests
Passed all 1 tests
xfstests results 201604270052 - 4.6.0-rc4-ext4-00009-g46ceec9 (Your 2/3 patch)
Failures: generic/231 <=== this is why I thought this commit was the regression
Passed all 1 tests
Passed all 1 tests
Passed all 1 tests
Passed all 1 tests
Passed all 1 tests
Passed all 1 tests
Passed all 1 tests
Passed all 1 tests
Failures: generic/231
xfstests results 201604270046 - 4.6.0-rc4-ext4-00010-geed525e (Your 3/3 patch)
Failures: generic/231
Failures: generic/231
Failures: generic/231
Failures: generic/231
Failures: generic/231
Passed all 1 tests
Passed all 1 tests
Passed all 1 tests
Passed all 1 tests
Failures: generic/231
So enabling per-file data journalling and delalloc is definitely makes
the problem much more visible, but it looks like it was always there.
Apologies for the initial misdiagnosis....
- Ted
next prev parent reply other threads:[~2016-04-27 14:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 8:04 [PATCH v4 2/3] ext4: fix races between changing inode journal mode and ext4_writepages Daeho Jeong
2016-04-27 14:30 ` Theodore Ts'o [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-04-29 1:06 Daeho Jeong
2016-03-14 2:34 [PATCH v4 1/3] ext4: handle unwritten or delalloc buffers before enabling per-file data journaling Daeho Jeong
2016-03-14 2:34 ` [PATCH v4 2/3] ext4: fix races between changing inode journal mode and ext4_writepages Daeho Jeong
2016-03-14 7:43 ` Jan Kara
2016-04-27 5:05 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160427143032.GG30021@thunk.org \
--to=tytso@mit.edu \
--cc=daeho.jeong@samsung.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).