linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH v4 2/3] ext4: fix races between changing inode journal mode and ext4_writepages
@ 2016-04-27  8:04 Daeho Jeong
  2016-04-27 14:30 ` Theodore Ts'o
  0 siblings, 1 reply; 6+ messages in thread
From: Daeho Jeong @ 2016-04-27  8:04 UTC (permalink / raw)
  To: Theodore Ts'o
  Cc: jack@suse.cz, 정대호,
	linux-ext4@vger.kernel.org

Oops, sorry about causing the regression.

But in the version I worked on, we passed the test case and
we still pass that. I executed the test case as belows.

kvm-xfstests -c 1k -C 10 generic/231

I am going to retry the test using GCE with the latest kernel version.
Sorry again.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v4 2/3] ext4: fix races between changing inode journal mode and ext4_writepages
@ 2016-04-29  1:06 Daeho Jeong
  0 siblings, 0 replies; 6+ messages in thread
From: Daeho Jeong @ 2016-04-29  1:06 UTC (permalink / raw)
  To: Theodore Ts'o
  Cc: jack@suse.cz, linux-ext4@vger.kernel.org,
	정대호

Hi Ted,

I fully understood your words and I have been executing generic/231 test case
again and again with linux-4.6.0-rc4, linux-4.6.0-rc5 and the latest source codes
of ext4 git server.

But, whenever I execute the test case, it is always passed.
I think the difference of the test results is originated from the difference between
your test environment and mine, however I cannot figure out that.

Actually, I just used kvm-xftests because GCE site cannot be accessed in
our company by security reasons.

Could you suggest some directions for me?

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH v4 1/3] ext4: handle unwritten or delalloc buffers before enabling per-file data journaling
@ 2016-03-14  2:34 Daeho Jeong
  2016-03-14  2:34 ` [PATCH v4 2/3] ext4: fix races between changing inode journal mode and ext4_writepages Daeho Jeong
  0 siblings, 1 reply; 6+ messages in thread
From: Daeho Jeong @ 2016-03-14  2:34 UTC (permalink / raw)
  To: tytso, jack, linux-ext4; +Cc: Daeho Jeong

We already allocate delalloc blocks before changing the inode mode into
"per-file data journal" mode to prevent delalloc blocks from remaining
not allocated, but another issue concerned with "BH_Unwritten" status
still exists. For example, by fallocate(), several buffers' status
change into "BH_Unwritten", but these buffers cannot be processed by
ext4_alloc_da_blocks(). So, they still remain in unwritten status after
per-file data journaling is enabled and they cannot be changed into
written status any more and, if they are journaled and eventually
checkpointed, these unwritten buffer will cause a kernel panic by the
below BUG_ON() function of submit_bh_wbc() when they are submitted
during checkpointing.

static int submit_bh_wbc(int rw, struct buffer_head *bh,...
{
        ...
        BUG_ON(buffer_unwritten(bh));

Moreover, when "dioread_nolock" option is enabled, the status of a
buffer is changed into "BH_Unwritten" after write_begin() completes and
the "BH_Unwritten" status will be cleared after I/O is done. Therefore,
if a buffer's status is changed into unwrutten but the buffer's I/O is
not submitted and completed, it can cause the same problem after
enabling per-file data journaling. You can easily generate this bug by
executing the following command.

./kvm-xfstests -C 10000 -m nodelalloc,dioread_nolock generic/269

To resolve these problems and define a boundary between the previous
mode and per-file data journaling mode, we need to flush and wait all
the I/O of buffers of a file before enabling per-file data journaling
of the file.

Signed-off-by: Daeho Jeong <daeho.jeong@samsung.com>
Reviewed-by: Jan Kara <jack@suse.cz>
---
 fs/ext4/inode.c |   31 ++++++++++++++++++++-----------
 1 file changed, 20 insertions(+), 11 deletions(-)

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index aee960b..71fab4c 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -5382,22 +5382,29 @@ int ext4_change_inode_journal_flag(struct inode *inode, int val)
 		return 0;
 	if (is_journal_aborted(journal))
 		return -EROFS;
-	/* We have to allocate physical blocks for delalloc blocks
-	 * before flushing journal. otherwise delalloc blocks can not
-	 * be allocated any more. even more truncate on delalloc blocks
-	 * could trigger BUG by flushing delalloc blocks in journal.
-	 * There is no delalloc block in non-journal data mode.
-	 */
-	if (val && test_opt(inode->i_sb, DELALLOC)) {
-		err = ext4_alloc_da_blocks(inode);
-		if (err < 0)
-			return err;
-	}
 
 	/* Wait for all existing dio workers */
 	ext4_inode_block_unlocked_dio(inode);
 	inode_dio_wait(inode);
 
+	/*
+	 * Before flushing the journal and switching inode's aops, we have
+	 * to flush all dirty data the inode has. There can be outstanding
+	 * delayed allocations, there can be unwritten extents created by
+	 * fallocate or buffered writes in dioread_nolock mode covered by
+	 * dirty data which can be converted only after flushing the dirty
+	 * data (and journalled aops don't know how to handle these cases).
+	 */
+	if (val) {
+		down_write(&EXT4_I(inode)->i_mmap_sem);
+		err = filemap_write_and_wait(inode->i_mapping);
+		if (err < 0) {
+			up_write(&EXT4_I(inode)->i_mmap_sem);
+			ext4_inode_resume_unlocked_dio(inode);
+			return err;
+		}
+	}
+
 	jbd2_journal_lock_updates(journal);
 
 	/*
@@ -5422,6 +5429,8 @@ int ext4_change_inode_journal_flag(struct inode *inode, int val)
 	ext4_set_aops(inode);
 
 	jbd2_journal_unlock_updates(journal);
+	if (val)
+		up_write(&EXT4_I(inode)->i_mmap_sem);
 	ext4_inode_resume_unlocked_dio(inode);
 
 	/* Finally we can mark the inode as dirty. */
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-04-29  1:06 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-27  8:04 [PATCH v4 2/3] ext4: fix races between changing inode journal mode and ext4_writepages Daeho Jeong
2016-04-27 14:30 ` Theodore Ts'o
  -- strict thread matches above, loose matches on Subject: below --
2016-04-29  1:06 Daeho Jeong
2016-03-14  2:34 [PATCH v4 1/3] ext4: handle unwritten or delalloc buffers before enabling per-file data journaling Daeho Jeong
2016-03-14  2:34 ` [PATCH v4 2/3] ext4: fix races between changing inode journal mode and ext4_writepages Daeho Jeong
2016-03-14  7:43   ` Jan Kara
2016-04-27  5:05   ` Theodore Ts'o

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).