From: Jan Kara <jack@suse.cz>
To: Calvin Owens <calvinowens@fb.com>
Cc: Jan Kara <jack@suse.cz>, linux-ext4@vger.kernel.org, kernel-team@fb.com
Subject: Re: WARNING at fs/ext4/inode.c ext4_evict_inode() triggers on 4.0
Date: Thu, 16 Jun 2016 10:33:04 +0200 [thread overview]
Message-ID: <20160616083304.GD22835@quack2.suse.cz> (raw)
In-Reply-To: <20160615204939.GA52455@calvinowens-mba.dhcp.thefacebook.com>
Hi Calvin,
On Wed 15-06-16 16:49:39, Calvin Owens wrote:
> I'm hitting the following warning on a 4.0 kernel:
>
> WARNING: CPU: 15 PID: 1005611 at fs/ext4/inode.c:233 ext4_evict_inode+0x4be/0x4d0()
> CPU: 15 PID: 1005611 Comm: rocksdb:bg0 Not tainted 4.0.9-60_fbk10_rc1_3974_g796b9b6 #1
> Call Trace:
> [<ffffffff8176af8e>] dump_stack+0x4d/0x63
> [<ffffffff8106c4dc>] warn_slowpath_common+0x8c/0xd0
> [<ffffffff8106c5da>] warn_slowpath_null+0x1a/0x20
> [<ffffffff81242c0e>] ext4_evict_inode+0x4be/0x4d0
> [<ffffffff811d248b>] evict+0xbb/0x190
> [<ffffffff811d2d6d>] iput+0x17d/0x1e0
> [<ffffffff811ce0e0>] __dentry_kill+0x190/0x1e0
> [<ffffffff811ce2d1>] dput+0x1a1/0x1f0
> [<ffffffff811b952a>] __fput+0x17a/0x210
> [<ffffffff811b960e>] ____fput+0xe/0x10
> [<ffffffff81086dbf>] task_work_run+0xbf/0x100
> [<ffffffff81002bcc>] do_notify_resume+0x7c/0x90
> [<ffffffff81771529>] int_signal+0x12/0x17
>
> Commit 822dbba ("ext4: fix warning in ext4_evict_inode()") proportedly fixed
> this in 3.11. The check was entirely removed in 4.6.
OK, so this is the warning:
WARN_ON(atomic_read(&EXT4_I(inode)->i_ioend_count));
It was removed in 4.6 since we maintained i_ioend_count only to be able to
do this check and it didn't trigger for a long time. So it is interesting
that it actually triggered for you with 4.0.
> Is it interesting to you that this triggers on 4.0? I can revert 600be30 and
> see if I can reproduce it on upstream, but since the check got removed I
> was wondering if there was post-4.0 work that makes it obsolete?
It would be great. I'm attaching a revert and an additional debug patch. If
you can run with these two on the latest kernel (or even just apply the debug
patch on top of 4.0) and reproduce the issue with it, I would be grateful.
Also if you reproduce the issue, please send me also your System.map so that
I can map the address of the function where ioend was created. Thanks!
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2016-06-16 8:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 20:49 WARNING at fs/ext4/inode.c ext4_evict_inode() triggers on 4.0 Calvin Owens
2016-06-16 8:33 ` Jan Kara [this message]
2016-06-17 17:40 ` Calvin Owens
2016-06-17 18:04 ` Jan Kara
2016-06-30 7:00 ` Jan Kara
2016-07-08 0:24 ` Calvin Owens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160616083304.GD22835@quack2.suse.cz \
--to=jack@suse.cz \
--cc=calvinowens@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).