From: Jan Kara <jack@suse.cz>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Jan Kara <jack@suse.cz>, Theodore Ts'o <tytso@mit.edu>,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH -v2] ext4: optimize ext4_should_retry_alloc() to improve ENOSPC performance
Date: Fri, 17 Jun 2016 12:10:07 +0200 [thread overview]
Message-ID: <20160617101007.GA26350@quack2.suse.cz> (raw)
In-Reply-To: <017458DB-A479-4462-BB81-30C321F593B4@dilger.ca>
On Thu 16-06-16 14:11:28, Andreas Dilger wrote:
> On Jun 16, 2016, at 1:20 PM, Jan Kara <jack@suse.cz> wrote:
> >
> > Well, since ext4_mb_free_metadata() is the only user of
> > ext4_journal_callback_add(), ext4_journal_callback_add() won't have any
> > user after your patch. Maybe we could just stop playing these abstraction
> > games nobody currently uses and just implement a helper function to add
> > freeing callback to the transaction list including increment of the pending
> > counter.
>
> We use the journal callback for Lustre servers. Please don't remove it.
I didn't really mean to rewrite the callback infrastructure. I just meant
to change the helper function to fit in-tree users. If Lustre needs to do
something else, it is free to have its own helper function which attaches
callbacks to the transaction's list.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2016-06-17 10:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 2:36 [PATCH] ext4: optimize ext4_should_retry_alloc() to improve ENOSPC performance Theodore Ts'o
2016-06-08 2:46 ` [PATCH -v2] " Theodore Ts'o
2016-06-08 3:16 ` Andreas Dilger
2016-06-16 19:20 ` Jan Kara
2016-06-16 20:11 ` Andreas Dilger
2016-06-17 10:10 ` Jan Kara [this message]
2016-06-30 15:00 ` [PATCH -v3] " Theodore Ts'o
2016-07-06 12:43 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160617101007.GA26350@quack2.suse.cz \
--to=jack@suse.cz \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).