From: Jan Kara <jack@suse.cz>
To: Wang Shilong <wangshilong1991@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] jbd2: wake up j_wait_done_commit before commit callback
Date: Mon, 20 Jun 2016 16:45:09 +0200 [thread overview]
Message-ID: <20160620144509.GF6882@quack2.suse.cz> (raw)
In-Reply-To: <1466048728-4325-1-git-send-email-wangshilong1991@gmail.com>
On Thu 16-06-16 12:45:28, Wang Shilong wrote:
> From: Wang Shilong <wshilong@ddn.com>
>
> Lustre register some callbacks in ext4 to keep data consistency,
> we see millons callbacks possibility on MDS for metadata operations.
>
> If there are many commit callbacks which might take some cpu
> time, we can mark commit done before we call commit callback.
> this can relax some thread waiting for commit finished, for example
> transaction throttle in end transaction.
>
> Signed-off-by: Wang Shilong <wshilong@ddn.com>
This is wrong - the commit callbacks will mark blocks free in bitmaps and
ext4_should_retry_alloc() relies on the fact that once commit is reported
as completed, all blocks freed in the committed transaction are really free
in the bitmaps. This patch breaks the assumption. And Ted's optimization,
which is BTW buggy, doesn't change anything on that...
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2016-06-20 15:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 3:45 [PATCH] jbd2: wake up j_wait_done_commit before commit callback Wang Shilong
2016-06-17 10:05 ` Wang Shilong
2016-06-22 11:04 ` Wang Shilong
2016-06-20 14:45 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620144509.GF6882@quack2.suse.cz \
--to=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=wangshilong1991@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).