From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jan Kara <jack@suse.cz>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] ext4: underflow in alignment check
Date: Mon, 20 Jun 2016 22:53:26 +0300 [thread overview]
Message-ID: <20160620195325.GM32247@mwanda> (raw)
In-Reply-To: <20160620160204.GG6882@quack2.suse.cz>
On Mon, Jun 20, 2016 at 06:02:04PM +0200, Jan Kara wrote:
> On Thu 16-06-16 10:07:09, Dan Carpenter wrote:
> > My static checker complains that this can underflow if arg is negative
> > which is true.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> How come? (1 << 30) fits even into 32-bit signed type. So where's the
> problem?
Bad changelog... I was talking about a different issue. I was casting
it to unsigned to take advantage of type promototion. Assume we have:
int arg = 1 << 31;
(arg > (1 << 30)) // <-- this is false
(arg > (1U << 30)) // <-- this is true so there is no underflow.
regards,
dan carpenter
next prev parent reply other threads:[~2016-06-20 19:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 7:07 [patch] ext4: underflow in alignment check Dan Carpenter
2016-06-20 16:02 ` Jan Kara
2016-06-20 19:53 ` Dan Carpenter [this message]
2016-06-21 7:43 ` Jan Kara
2016-06-21 13:06 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620195325.GM32247@mwanda \
--to=dan.carpenter@oracle.com \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).