From: Theodore Ts'o <tytso@mit.edu>
To: Daeho Jeong <daeho.jeong@samsung.com>
Cc: darrick.wong@oracle.com, linux-ext4@vger.kernel.org,
Youngjin Gil <youngjin.gil@samsung.com>
Subject: Re: [PATCH] ext4: avoid modifying checksum fields directly during checksum verification
Date: Sun, 3 Jul 2016 18:05:13 -0400 [thread overview]
Message-ID: <20160703220513.GB17739@thunk.org> (raw)
In-Reply-To: <1465971173-5612-1-git-send-email-daeho.jeong@samsung.com>
On Wed, Jun 15, 2016 at 03:12:53PM +0900, Daeho Jeong wrote:
> We temporally change checksum fields in buffers of some types of
> metadata into '0' for verifying the checksum values. By doing this
> without locking the buffer, some metadata's checksums, which are
> being committed or written back to the storage, could be damaged.
> In our test, several metadata blocks were found with damaged metadata
> checksum value during recovery process. When we only verify the
> checksum value, we have to avoid modifying checksum fields directly.
>
> Signed-off-by: Daeho Jeong <daeho.jeong@samsung.com>
> Signed-off-by: Youngjin Gil <youngjin.gil@samsung.com>
Applied, thanks!
- Ted
prev parent reply other threads:[~2016-07-03 22:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 6:12 [PATCH] ext4: avoid modifying checksum fields directly during checksum verification Daeho Jeong
2016-06-15 21:57 ` Darrick J. Wong
[not found] ` <CGME20160615215745epcas1p311ceb996b59406165c213da4de9196c4@epcas1p3.samsung.com>
2016-06-16 0:08 ` Daeho Jeong
2016-07-03 22:05 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160703220513.GB17739@thunk.org \
--to=tytso@mit.edu \
--cc=daeho.jeong@samsung.com \
--cc=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=youngjin.gil@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).