From: Theodore Ts'o <tytso@mit.edu>
To: Daeho Jeong <daeho.jeong@samsung.com>
Cc: linux-ext4@vger.kernel.org, Youngjin Gil <youngjin.gil@samsung.com>
Subject: Re: [PATCH RESEND] e2fsck: update j_tail_sequence after recovery
Date: Tue, 5 Jul 2016 23:11:15 -0400 [thread overview]
Message-ID: <20160706031115.GO15193@thunk.org> (raw)
In-Reply-To: <1467763839-10311-1-git-send-email-daeho.jeong@samsung.com>
On Wed, Jul 06, 2016 at 09:10:39AM +0900, Daeho Jeong wrote:
> When journal is released, s_sequence is set to j_tail_sequence.
> But, currently, even if the recovery process is successfully completed,
> the j_tail_sequence and, finally, s_sequence are never changed. By this,
> when we repeat doing power-off the device suddenly and executing e2fsck
> without full scan before mount, the s_sequence number will never change
> and, in a very rare case, newly generated journal logs will be
> surprisingly grafted to the old journal logs. In this case, out-of-date
> metadata log can be replayed on the filesystem area and the filesystem
> can be crashed unintentionally by journal recovery process. Therefore,
> we need to update j_tail_sequence after recovery process is successfully
> completed in e2fsck.
>
> Youngjin had repeated this test and found the problem. With our test,
> the filesystem crash occurred within 4 hours.
>
> Signed-off-by: Youngjin Gil <youngjin.gil@samsung.com>
> Signed-off-by: Daeho Jeong <daeho.jeong@samsung.com>
Applied, thanks.
- Ted
prev parent reply other threads:[~2016-07-06 3:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 0:10 [PATCH RESEND] e2fsck: update j_tail_sequence after recovery Daeho Jeong
2016-07-06 3:11 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160706031115.GO15193@thunk.org \
--to=tytso@mit.edu \
--cc=daeho.jeong@samsung.com \
--cc=linux-ext4@vger.kernel.org \
--cc=youngjin.gil@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).