From: Theodore Ts'o <tytso@mit.edu>
To: Wang Shilong <wangshilong1991@gmail.com>
Cc: Eric Sandeen <sandeen@redhat.com>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
Shuichi Ihara <sihara@ddn.com>, Li Xi <lixi@ddn.com>,
Wang Shilong <wshilong@ddn.com>
Subject: Re: [PATCH] ext4: add project quota mount options
Date: Fri, 8 Jul 2016 00:48:21 -0400 [thread overview]
Message-ID: <20160708044821.GG19871@thunk.org> (raw)
In-Reply-To: <CAP9B-Qm_fuw3rNGyc4068YADbOisjVm=35=siChgks4=v62qtw@mail.gmail.com>
On Fri, Jul 08, 2016 at 12:36:56PM +0900, Wang Shilong wrote:
>
> I do agree with your point here, but the problem is as you can see come
> from xfstests arguments from Dave Chinner.
>
> I don't think currently users will try to old interface with project quota.
> But as your request, i think you need some tests for project quota...
I think we need some real clarity about exactly what Dave is asking
for. I think what Eric and Dave have been asking for is testing both
of these two different quota management stacks:
(1) XFS has ioctl's which come from the Irix days, and these are used by
the xfs quota utilities.
(2) Quotatools uses the quotactl(2) system call, and so there is an
entirely **different** code path which we can exercise.
This is a completely orthogonal question from which mount options and
which mkfs options are used to set up project quota support for ext4.
That's an ext4-specific concern, and I don't see why Dave would have
any interest in what ext4 chooses to support here.
- Ted
next prev parent reply other threads:[~2016-07-08 4:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 7:09 [PATCH] ext4: add project quota mount options Wang Shilong
2016-07-07 16:06 ` Eric Sandeen
2016-07-08 0:41 ` Wang Shilong
2016-07-08 3:10 ` Theodore Ts'o
2016-07-08 3:36 ` Wang Shilong
2016-07-08 4:48 ` Theodore Ts'o [this message]
2016-07-11 15:29 ` Jan Kara
2016-07-07 18:15 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160708044821.GG19871@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=lixi@ddn.com \
--cc=sandeen@redhat.com \
--cc=sihara@ddn.com \
--cc=wangshilong1991@gmail.com \
--cc=wshilong@ddn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).