From: Jan Kara <jack@suse.cz>
To: Wang Shilong <wangshilong1991@gmail.com>
Cc: Jan Kara <jack@suse.cz>, Theodore Ts'o <tytso@mit.edu>,
Eric Sandeen <sandeen@sandeen.net>,
Dave Chinner <david@fromorbit.com>,
fstests@vger.kernel.org,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
Shuichi Ihara <sihara@ddn.com>, Li Xi <lixi@ddn.com>,
Wang Shilong <wshilong@ddn.com>
Subject: Re: [PATCH v2] xfstests, generic: add project quota attribute tests
Date: Mon, 18 Jul 2016 12:20:56 +0200 [thread overview]
Message-ID: <20160718102056.GA6782@quack2.suse.cz> (raw)
In-Reply-To: <CAP9B-Qn0R1geR41BH-Eg6sqYUid734ar6Nq4sYyjK5PCrWFzAg@mail.gmail.com>
On Fri 15-07-16 10:15:31, Wang Shilong wrote:
> On Thu, Jul 14, 2016 at 10:13 PM, Jan Kara <jack@suse.cz> wrote:
> > On Tue 12-07-16 12:15:47, Ted Tso wrote:
>
> >> Does that sound like a plan?
> >
> > Yes. quotaoff will already disable only enforcement for ext4 with hidden
> > quota files so there's no need to change anything there. We just need to
> > add kernel support for enabling quota enforcement based on mount option.
> > Attached patch should do that - I still need to test whether it doesn't
> > break anything so don't apply it yet, just have a look whether it looks
> > sane to you.
>
> I sent a similar patch weeks ago.
> http://marc.info/?l=linux-ext4&m=146787897927183&w=2
Your patch was actually quite different. It did implement prjquota option
but the option did something else than in my patch... In your patch you
implemented prjquota option to match the behavior of original quota in
normal files. In my patch I've implemented behavior of prjquota option to
behave similarly as in XFS - i.e. enable enforcement of project quotas when
project quota feature is enabled.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2016-07-18 10:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 6:22 [PATCH v2] xfstests, generic: add project quota attribute tests Wang Shilong
2016-07-06 16:10 ` Eric Sandeen
2016-07-06 23:35 ` Dave Chinner
2016-07-07 2:47 ` Eric Sandeen
2016-07-08 0:51 ` Dave Chinner
2016-07-08 2:46 ` Theodore Ts'o
2016-07-08 3:19 ` Eric Sandeen
2016-07-08 4:57 ` Dave Chinner
2016-07-08 5:02 ` Theodore Ts'o
2016-07-11 16:15 ` Jan Kara
2016-07-11 17:12 ` Theodore Ts'o
2016-07-12 10:59 ` Jan Kara
2016-07-12 14:32 ` Jan Kara
2016-07-12 16:15 ` Theodore Ts'o
2016-07-14 13:13 ` Jan Kara
2016-07-15 1:15 ` Wang Shilong
2016-07-18 10:20 ` Jan Kara [this message]
2016-07-18 12:45 ` Wang Shilong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160718102056.GA6782@quack2.suse.cz \
--to=jack@suse.cz \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=lixi@ddn.com \
--cc=sandeen@sandeen.net \
--cc=sihara@ddn.com \
--cc=tytso@mit.edu \
--cc=wangshilong1991@gmail.com \
--cc=wshilong@ddn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).