From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Dave Chinner <david@fromorbit.com>,
Eric Sandeen <sandeen@redhat.com>,
linux-ext4@vger.kernel.org
Subject: Re: [4.7-rc6 ext3 BUG] kernel BUG at fs/ext4/xattr.c:1331
Date: Mon, 1 Aug 2016 09:09:05 -0400 [thread overview]
Message-ID: <20160801130905.GH12853@thunk.org> (raw)
In-Reply-To: <20160801121930.GB19431@quack2.suse.cz>
On Mon, Aug 01, 2016 at 02:19:30PM +0200, Jan Kara wrote:
>
> Relatively simple but there are still some bugs lurking - I have the
> original issue fixed but I have implemented xfstests which stress the inode
> expansion code in various ways and so far they are still able to crash the
> kernel... Tomorrow I will be looking more into it and hopefully will be
> able to finish the fixes.
Great, thanks. I'll wait and see how your patches work out. If we
think all of the patches are simple/low-risk enough for -stable
material, I'd much rather go with a proper fix.
> Regarding your patch - I think it's a reasonable band-aid although I'll
> have to backport proper fixes to 4.4 anyway (it's a base of our next
> enterprise release), which is where i_projid got introduced as well, so
> eventually we will have proper stable fixes for all relevant kernels
> anyway.
Well, it depends on whether you intend to support upgrading an
existing file system or require users to run mkfs.ext4 before being
able to take advantage of the new feature. Red Hat is much more
conservative and has historically only supported running mke2fs from
scratch --- which probably made sense from their QA department's POV,
anyway. The band-aid patch is enough if you don't suppor "tune2fs -O
project", but only "mke2fs -t ext4 -O project". I'd personally prefer
upstream to support both flawlesssly, so I'm thankful for your work to
fix things properly, but enterprise distros can be extremely
conservative.
Cheers,
- Ted
next prev parent reply other threads:[~2016-08-01 13:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 2:23 [4.7-rc6 ext3 BUG] kernel BUG at fs/ext4/xattr.c:1331 Dave Chinner
2016-07-18 3:02 ` Dave Chinner
2016-07-18 4:07 ` Eric Sandeen
2016-07-18 5:24 ` Dave Chinner
2016-07-28 13:54 ` Jan Kara
2016-07-29 0:21 ` Dave Chinner
2016-07-29 6:42 ` Jan Kara
2016-08-01 3:09 ` Theodore Ts'o
2016-08-01 12:19 ` Jan Kara
2016-08-01 13:09 ` Theodore Ts'o [this message]
2016-08-04 16:18 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160801130905.GH12853@thunk.org \
--to=tytso@mit.edu \
--cc=david@fromorbit.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).