From: Eric Whitney <enwlinux@gmail.com>
To: fstests@vger.kernel.org
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu
Subject: [PATCH] generic/135: redirect stderr from _scratch_mkfs
Date: Thu, 18 Aug 2016 11:04:56 -0400 [thread overview]
Message-ID: <20160818150456.GB14069@localhost.localdomain> (raw)
In generic/135, benign warning message output from _scratch_mkfs on
stderr can cause a golden output mismatch, as can occur when testing
an ext4 bigalloc file system. It's the only generic test that does not
also redirect stderr when directing _scratch_mkfs' stdout to /dev/null.
Since error output from _scratch_mkfs doesn't seem important to the
overall intent of the test, there should be no harm in making its
stderr handling consistent.
Signed-off-by: Eric Whitney <enwlinux@gmail.com>
---
tests/generic/135 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/generic/135 b/tests/generic/135
index 52418f6..14b8132 100755
--- a/tests/generic/135
+++ b/tests/generic/135
@@ -41,7 +41,7 @@ _supported_os Linux IRIX
_require_odirect
_require_scratch
-_scratch_mkfs >/dev/null
+_scratch_mkfs >/dev/null 2>&1
_scratch_mount
cd $SCRATCH_MNT
--
2.1.4
reply other threads:[~2016-08-18 15:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160818150456.GB14069@localhost.localdomain \
--to=enwlinux@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).