linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] generic/135: redirect stderr from _scratch_mkfs
@ 2016-08-18 15:04 Eric Whitney
  0 siblings, 0 replies; only message in thread
From: Eric Whitney @ 2016-08-18 15:04 UTC (permalink / raw)
  To: fstests; +Cc: linux-ext4, tytso

In generic/135, benign warning message output from _scratch_mkfs on
stderr can cause a golden output mismatch, as can occur when testing
an ext4 bigalloc file system.  It's the only generic test that does not
also redirect stderr when directing _scratch_mkfs' stdout to /dev/null.
Since error output from _scratch_mkfs doesn't seem important to the
overall intent of the test, there should be no harm in making its
stderr handling consistent.

Signed-off-by: Eric Whitney <enwlinux@gmail.com>
---
 tests/generic/135 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/135 b/tests/generic/135
index 52418f6..14b8132 100755
--- a/tests/generic/135
+++ b/tests/generic/135
@@ -41,7 +41,7 @@ _supported_os Linux IRIX
 
 _require_odirect
 _require_scratch
-_scratch_mkfs >/dev/null
+_scratch_mkfs >/dev/null 2>&1
 _scratch_mount
 
 cd $SCRATCH_MNT
-- 
2.1.4

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-08-18 15:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-18 15:04 [PATCH] generic/135: redirect stderr from _scratch_mkfs Eric Whitney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).