From: Eric Whitney <enwlinux@gmail.com>
To: fstests@vger.kernel.org
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu
Subject: [PATCH V2] common/rc: improve _require_metadata_journaling() for ext4
Date: Fri, 19 Aug 2016 12:47:38 -0400 [thread overview]
Message-ID: <20160819164738.GA1903@localhost.localdomain> (raw)
The code in _require_metadata_journaling() currently rejects ext4 file
systems that have been created without a journal. However, an ext4
file system with a journal should also be rejected if the journal is
not loaded and made available for use at mount time.
V2: Replaced code with call to _exclude_scratch_mount_option() per
review comment.
Signed-off-by: Eric Whitney <enwlinux@gmail.com>
---
common/rc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/common/rc b/common/rc
index 3fb0600..9d1fc07 100644
--- a/common/rc
+++ b/common/rc
@@ -3057,6 +3057,8 @@ _require_metadata_journaling()
_require_dumpe2fs
$DUMPE2FS_PROG -h $DEV 2>&1 | grep -q has_journal || \
_notrun "$FSTYP on $DEV not configured with metadata journaling"
+ # ext4 might not load a journal
+ _exclude_scratch_mount_option "noload"
;;
*)
# by default we pass; if you need to, add your fs above!
--
2.1.4
reply other threads:[~2016-08-19 16:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160819164738.GA1903@localhost.localdomain \
--to=enwlinux@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).