* [PATCH V2] common/rc: improve _require_metadata_journaling() for ext4
@ 2016-08-19 16:47 Eric Whitney
0 siblings, 0 replies; only message in thread
From: Eric Whitney @ 2016-08-19 16:47 UTC (permalink / raw)
To: fstests; +Cc: linux-ext4, tytso
The code in _require_metadata_journaling() currently rejects ext4 file
systems that have been created without a journal. However, an ext4
file system with a journal should also be rejected if the journal is
not loaded and made available for use at mount time.
V2: Replaced code with call to _exclude_scratch_mount_option() per
review comment.
Signed-off-by: Eric Whitney <enwlinux@gmail.com>
---
common/rc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/common/rc b/common/rc
index 3fb0600..9d1fc07 100644
--- a/common/rc
+++ b/common/rc
@@ -3057,6 +3057,8 @@ _require_metadata_journaling()
_require_dumpe2fs
$DUMPE2FS_PROG -h $DEV 2>&1 | grep -q has_journal || \
_notrun "$FSTYP on $DEV not configured with metadata journaling"
+ # ext4 might not load a journal
+ _exclude_scratch_mount_option "noload"
;;
*)
# by default we pass; if you need to, add your fs above!
--
2.1.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-08-19 16:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-19 16:47 [PATCH V2] common/rc: improve _require_metadata_journaling() for ext4 Eric Whitney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).