linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Whitney <enwlinux@gmail.com>
To: Eryu Guan <eguan@redhat.com>
Cc: Eric Whitney <enwlinux@gmail.com>,
	fstests@vger.kernel.org, linux-ext4@vger.kernel.org,
	tytso@mit.edu
Subject: Re: [PATCH] common/rc: improve _require_metadata_journaling() for ext4
Date: Fri, 19 Aug 2016 12:56:04 -0400	[thread overview]
Message-ID: <20160819165604.GB1903@localhost.localdomain> (raw)
In-Reply-To: <20160818152620.GC27776@eguan.usersys.redhat.com>

> 
> I think this can be done by the new helper _exclude_scratch_mount_option
> which was introduced recently, e.g.
> 
_exclude_scratch_mount_option "noload"

This function would be better named if it didn't include "_scratch", since
it isn't scratch-specific.  That would make it easier for the occasional
contributor/reader to recognize it for what it is at a glance.

Also, its header comment references MKFS_OPTIONS rather than MOUNT_OPTIONS.

Thanks,
Eric

> 
> Thanks,
> Eryu

      reply	other threads:[~2016-08-19 16:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-18 14:42 [PATCH] common/rc: improve _require_metadata_journaling() for ext4 Eric Whitney
2016-08-18 15:26 ` Eryu Guan
2016-08-19 16:56   ` Eric Whitney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160819165604.GB1903@localhost.localdomain \
    --to=enwlinux@gmail.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).