From: Theodore Ts'o <tytso@mit.edu>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Anatoly Pugachev <matorola@gmail.com>,
linux-ext4@vger.kernel.org,
debian-sparc <debian-sparc@lists.debian.org>
Subject: Re: [sparc64] sigbus in e2fsck
Date: Wed, 31 Aug 2016 21:26:20 -0400 [thread overview]
Message-ID: <20160901012620.au5syxdjha4aedlm@thunk.org> (raw)
In-Reply-To: <20160830202510.GA8258@birch.djwong.org>
On Tue, Aug 30, 2016 at 01:25:10PM -0700, Darrick J. Wong wrote:
>
> AFAICT, each bh is malloc'd via e2fsck_allocate_memory and nothing seems
> to guarantee that the char b_data[1024] will be aligned to a multiple of
> 8 (it certainly isn't on x64), so I guess this isn't much of a surprise.
>
> We could change b_data to a pointer and then posix_memalign it.
Actually, all we need to do is to rearrange the structure elements so
it looks like this:
unsigned long long b_blocknr;
char b_data[1024];
};
Since b_blocknr will need to be eight byte aligned, this will also
ensure that b_data will also be aligned correctly.
- Ted
next prev parent reply other threads:[~2016-09-02 6:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 12:42 [sparc64] sigbus in e2fsck Anatoly Pugachev
2016-08-30 12:56 ` John Paul Adrian Glaubitz
2016-08-30 14:58 ` Theodore Ts'o
2016-08-30 15:03 ` John Paul Adrian Glaubitz
2016-08-30 15:12 ` Anatoly Pugachev
2016-08-30 19:16 ` Theodore Ts'o
2016-08-30 20:17 ` Anatoly Pugachev
2016-08-30 20:25 ` Darrick J. Wong
2016-09-01 1:26 ` Theodore Ts'o [this message]
2016-08-30 16:45 ` Jose E. Marchesi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160901012620.au5syxdjha4aedlm@thunk.org \
--to=tytso@mit.edu \
--cc=darrick.wong@oracle.com \
--cc=debian-sparc@lists.debian.org \
--cc=linux-ext4@vger.kernel.org \
--cc=matorola@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox