From: Eric Biggers <ebiggers@google.com>
To: Theodore Ts'o <tytso@mit.edu>,
Richard Weinberger <richard@nod.at>,
adilger.kernel@dilger.ca, linux-kernel@vger.kernel.org,
linux-ext4@vger.kernel.org, david@sigma-star.at,
jaegeuk@kernel.org
Subject: Re: [PATCH] ext4: Check for encryption feature before fscrypt_process_policy()
Date: Fri, 23 Sep 2016 14:56:54 -0700 [thread overview]
Message-ID: <20160923215654.GB106495@google.com> (raw)
In-Reply-To: <20160922223803.ggz2qodtqtht7oot@thunk.org>
On Thu, Sep 22, 2016 at 06:38:03PM -0400, Theodore Ts'o wrote:
>
> I think it's fine to fix it now in upstream. It might cause some
> problems for Cyanogen developers if they want to try to use an
> upstream kernel and also enable the ext4 encryption feature, but the
> fix to make_ext4fs isn't all that hard.
Would it make sense to at least provide a helpful error message in the kernel
log? For example:
if (!ext4_has_feature_encrypt(sb)) {
ext4_msg(sb, KERN_INFO,
"warning: process `%s' tried to set "
"encryption policy on filesystem without "
"encryption enabled. This is not supported. "
"Use 'tune2fs -O encrypt' to enable the "
"encryption feature flag first.",
current->comm);
return -EOPNOTSUPP;
}
Eric
next prev parent reply other threads:[~2016-09-23 21:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 6:50 [PATCH] ext4: Check for encryption feature before fscrypt_process_policy() Richard Weinberger
2016-09-22 19:49 ` Eric Biggers
2016-09-22 20:17 ` Richard Weinberger
2016-09-22 22:38 ` Theodore Ts'o
2016-09-23 21:56 ` Eric Biggers [this message]
2016-09-30 5:53 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923215654.GB106495@google.com \
--to=ebiggers@google.com \
--cc=adilger.kernel@dilger.ca \
--cc=david@sigma-star.at \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).