From: Eric Biggers <ebiggers@google.com>
To: Richard Weinberger <richard@nod.at>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Theodore Ts'o <tytso@mit.edu>,
jaegeuk@kernel.org, David Gstir <david@sigma-star.at>
Subject: Re: [PATCH] fscrypto: make XTS tweak initialization endian-independent
Date: Tue, 4 Oct 2016 09:38:29 -0700 [thread overview]
Message-ID: <20161004163829.GA127921@google.com> (raw)
In-Reply-To: <6c9b32ef-1e63-f721-1d7f-b0f1e0f2d1ca@nod.at>
On Tue, Oct 04, 2016 at 10:46:54AM +0200, Richard Weinberger wrote:
> > Also, currently this code *is* only supposed to be used for XTS. There's a bug
> > where a specially crafted filesystem can cause this code path to be entered with
> > CTS, but I have a patch pending in the ext4 tree to fix that.
>
> David and I are currently working on UBIFS encryption and we have to support other cipher
> modes than XTS. So, keeping fscrypto as generic as possible would be nice. :-)
>
The problem was that the kernel supported reading a file whose contents was
encrypted with CTS, which is only supposed to be used for filenames. This was
inconsistent with FS_IOC_SET_ENCRYPTION_POLICY which currently only allows XTS
for contents and CTS for filenames. So in other words I wanted to eliminate a
strange scenario that was not intended to happen and was almost certainly never
tested.
Either way, new modes can still be added if there is a good reason to do so.
What new encryption modes are you thinking of adding, would they be for contents
or for filenames, and are you thinking they would be offered by all filesystems
(ext4 and f2fs too)?
Eric
next prev parent reply other threads:[~2016-10-04 16:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 17:58 [PATCH] fscrypto: make XTS tweak initialization endian-independent Eric Biggers
2016-10-01 16:03 ` Richard Weinberger
2016-10-03 18:03 ` Eric Biggers
2016-10-04 8:46 ` Richard Weinberger
2016-10-04 16:38 ` Eric Biggers [this message]
2016-10-05 9:08 ` David Gstir
2016-10-13 3:39 ` Theodore Ts'o
[not found] <20161005170659.GA110549@google.com>
2016-10-05 18:23 ` Michael Halcrow
2016-10-05 18:44 ` Richard Weinberger
2016-10-05 21:11 ` Michael Halcrow
2016-10-05 21:18 ` Richard Weinberger
2016-10-05 21:14 ` Richard Weinberger
2016-10-06 1:17 ` Dave Chinner
2016-10-06 2:16 ` Theodore Ts'o
2016-10-06 22:23 ` Dave Chinner
2016-10-07 16:05 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161004163829.GA127921@google.com \
--to=ebiggers@google.com \
--cc=david@sigma-star.at \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=richard@nod.at \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).