From: Jan Kara <jack@suse.cz>
To: Eric Biggers <ebiggers@google.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: correct endianness conversion in __xattr_check_inode()
Date: Wed, 12 Oct 2016 12:36:46 +0200 [thread overview]
Message-ID: <20161012103646.GA14664@quack2.suse.cz> (raw)
In-Reply-To: <1476205286-136713-1-git-send-email-ebiggers@google.com>
On Tue 11-10-16 10:01:26, Eric Biggers wrote:
> It should be cpu_to_le32(), not le32_to_cpu(). No change in behavior.
>
> Found with sparse, and this was the only endianness warning in fs/ext4/.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Looks good. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/ext4/xattr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
> index c15d633..e90c5cd 100644
> --- a/fs/ext4/xattr.c
> +++ b/fs/ext4/xattr.c
> @@ -241,7 +241,7 @@ __xattr_check_inode(struct inode *inode, struct ext4_xattr_ibody_header *header,
> int error = -EFSCORRUPTED;
>
> if (((void *) header >= end) ||
> - (header->h_magic != le32_to_cpu(EXT4_XATTR_MAGIC)))
> + (header->h_magic != cpu_to_le32(EXT4_XATTR_MAGIC)))
> goto errout;
> error = ext4_xattr_check_names(entry, end, entry);
> errout:
> --
> 2.8.0.rc3.226.g39d4020
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2016-10-12 10:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 17:01 [PATCH] ext4: correct endianness conversion in __xattr_check_inode() Eric Biggers
2016-10-12 10:36 ` Jan Kara [this message]
2016-10-15 13:44 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012103646.GA14664@quack2.suse.cz \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=ebiggers@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).