From: Eric Whitney <enwlinux@gmail.com>
To: linux-ext4@vger.kernel.org
Cc: tytso@mit.edu
Subject: [PATCH] xfstests-bld: fix check script argument ordering bug
Date: Wed, 12 Oct 2016 17:38:12 -0400 [thread overview]
Message-ID: <20161012213812.GA8131@localhost.localdomain> (raw)
The check script called by runtests.sh in the test appliance to control
xfstest execution requires that all optional arguments precede any test
names on its command line. Violation of this requirement results in an
error message ("Arguments before tests, please!") and an immediate exit
without test execution.
runtests.sh violates this requirement when it runs a specific test in a
configuration that defines TEST_SET_EXCLUDE (contains -x argument).
To reproduce the bug, run "kvm-xfstests -c bigalloc generic/375".
Signed-off-by: Eric Whitney <enwlinux@gmail.com>
---
kvm-xfstests/test-appliance/files/root/runtests.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kvm-xfstests/test-appliance/files/root/runtests.sh b/kvm-xfstests/test-appliance/files/root/runtests.sh
index a9338dc..5e6c1f7 100755
--- a/kvm-xfstests/test-appliance/files/root/runtests.sh
+++ b/kvm-xfstests/test-appliance/files/root/runtests.sh
@@ -374,7 +374,7 @@ do
gce_run_hooks fs-config-begin $i
for j in $(seq 1 $RPT_COUNT) ; do
gce_run_hooks pre-xfstests $i $j
- bash ./check -T $AEX $FSTESTSET $TEST_SET_EXCLUDE
+ bash ./check -T $AEX $TEST_SET_EXCLUDE $FSTESTSET
gce_run_hooks post-xfstests $i $j
umount "$TEST_DEV" >& /dev/null
check_filesystem "$TEST_DEV" >& $RESULT_BASE/fsck.out
--
2.1.4
next reply other threads:[~2016-10-12 21:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 21:38 Eric Whitney [this message]
2016-10-14 16:25 ` [PATCH] xfstests-bld: fix check script argument ordering bug Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012213812.GA8131@localhost.localdomain \
--to=enwlinux@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).