From: Eric Biggers <ebiggers@google.com>
To: Richard Weinberger <richard@nod.at>
Cc: linux-fsdevel@vger.kernel.org, jaegeuk@kernel.org,
linux-ext4@vger.kernel.org, tytso@mit.edu,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH] fscrypto: lock inode while setting encryption policy
Date: Fri, 14 Oct 2016 11:11:52 -0700 [thread overview]
Message-ID: <20161014181152.GA65380@google.com> (raw)
In-Reply-To: <ea8b7140-f04e-380d-b5ae-263f029c0624@nod.at>
On Thu, Sep 29, 2016 at 07:20:20PM +0200, Richard Weinberger wrote:
> On 28.09.2016 20:34, Eric Biggers wrote:
> > i_rwsem needs to be acquired while setting an encryption policy so that
> > concurrent calls to FS_IOC_SET_ENCRYPTION_POLICY are correctly
> > serialized (especially the ->get_context() + ->set_context() pair), and
> > so that new files cannot be created in the directory during or after the
> > ->empty_dir() check.
> >
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
>
> Reviewed-by: Richard Weinberger <richard@nod.at>
>
> Thanks,
> //richard
Thanks. Does anyone else have comments on this patch? It hasn't been applied
yet.
Eric
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
next prev parent reply other threads:[~2016-10-14 18:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 18:34 [PATCH] fscrypto: lock inode while setting encryption policy Eric Biggers
2016-09-29 17:20 ` Richard Weinberger
2016-10-14 18:11 ` Eric Biggers [this message]
2016-10-15 13:54 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161014181152.GA65380@google.com \
--to=ebiggers@google.com \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=richard@nod.at \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).