From: Eric Biggers <ebiggers@google.com>
To: Richard Weinberger <richard.weinberger@gmail.com>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Theodore Ts'o <tytso@mit.edu>,
jaegeuk@kernel.org, David Gstir <david@sigma-star.at>
Subject: Re: [PATCH] fscrypto: move ioctl processing more fully into common code
Date: Tue, 18 Oct 2016 09:52:50 -0700 [thread overview]
Message-ID: <20161018165250.GA34034@google.com> (raw)
In-Reply-To: <CAFLxGvz8KV=zzy=fijEuK7qtCivS=A2BBpNvNksv4J06KTSmZw@mail.gmail.com>
On Tue, Oct 18, 2016 at 02:22:07PM +0200, Richard Weinberger wrote:
>
> Hmm, are you sure the change is worth it?
> The patch basically moves a copy_from/to_user() from ext4/f2fs into fscrypto.
>
Hi Richard,
In my opinion consolidating the copy_from/to_user() is worthwhile by itself.
The filesystem encryption code should be shared when possible, and right now
there's no reason for each filesystem to do its own copy_from/to_user().
The renaming to fscrypt_ioctl_* is also important because it makes it clear that
the functions implement ioctls. I've already fixed four bugs in the "set
policy" ioctl, and I think these bugs would have been more obvious with a
clearer code organization.
Eric
next prev parent reply other threads:[~2016-10-18 16:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 16:54 [PATCH] fscrypto: move ioctl processing more fully into common code Eric Biggers
2016-10-18 12:22 ` Richard Weinberger
2016-10-18 16:52 ` Eric Biggers [this message]
2016-11-22 23:15 ` Eric Biggers
2016-11-27 0:09 ` Theodore Ts'o
2016-11-27 4:20 ` Eric Biggers
2016-11-27 17:39 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161018165250.GA34034@google.com \
--to=ebiggers@google.com \
--cc=david@sigma-star.at \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=richard.weinberger@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).