From: Jan Kara <jack@suse.cz>
To: Eric Whitney <enwlinux@gmail.com>
Cc: linux-ext4@vger.kernel.org, jack@suse.cz, tytso@mit.edu
Subject: Re: generic/095 triggers lockdep warning in 4.9-rc1
Date: Fri, 21 Oct 2016 09:32:57 +0200 [thread overview]
Message-ID: <20161021073257.GA8271@quack2.suse.cz> (raw)
In-Reply-To: <20161020180400.GA2172@localhost.localdomain>
On Thu 20-10-16 14:04:00, Eric Whitney wrote:
> As reported in today's concall, generic/095 triggered a lockdep warning
> during my regression run on a 4.9-rc1 kernel in the 4k test case using the
> latest xfstests-bld test appliance. The warning is attached below, and
> involves both ext4's direct I/O path and the quota code.
>
> This failure is difficult to reproduce - 120 out of 120 subsequent trials in
> the 4k test case completed successfully. No generic/095 failures occurred in
> any other test appliance test case during regression. Also, I've not seen
> this particular failure in regression runs prior to 4.9-rc1.
Thanks for report. I've already seen that report in my testing as well and
I'm actually able to reproduce it pretty reliably. It is a result of
changes in lockdep annotation of fs freezing - in particular commit
f1a9622037cd370460fd06bb7e28d0f01ceb8ef1 "fs/super.c: don't fool lockdep in
freeze_super() and thaw_super() paths". And it is a real deadlock
possibility although it is probably close to impossible to hit in practice.
The immediate problem is with lock ranking of dqonoff_mutex which ranks
above fault freeze protection but during fs freezing it gets acquired with
fault freeze protection held. It it on my todo list to look into fixing
this but it won't be trivial so I didn't get to it yet.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2016-10-21 7:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 18:04 generic/095 triggers lockdep warning in 4.9-rc1 Eric Whitney
2016-10-21 7:32 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161021073257.GA8271@quack2.suse.cz \
--to=jack@suse.cz \
--cc=enwlinux@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).