From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/4] fs: Provide function to unmap metadata for a range of blocks
Date: Fri, 21 Oct 2016 05:05:42 -0700 [thread overview]
Message-ID: <20161021120542.GA20475@infradead.org> (raw)
In-Reply-To: <1477050941-29682-2-git-send-email-jack@suse.cz>
> + * Functionally, this is like unmap_underlying_metadata() for a range of
> + * blocks. It is implemented to be more efficient for larger ranges of blocks
> + * though.
> + */
> +void unmap_underlying_metadata_ext(struct block_device *bdev, sector_t block,
> + sector_t len)
Please explain what it does and why you'd call it. And while we're
naming I think the 'metadata' part is highly confusing. What it does
is to clear buffers from the block device mapping, nothing about
metadata really.
So how about unmap_buffers_range or similar?
next prev parent reply other threads:[~2016-10-21 12:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 11:55 [PATCH 0/4] fs: Provide function to unmap metadata for a range of blocks Jan Kara
2016-10-21 11:55 ` [PATCH 1/4] " Jan Kara
2016-10-21 12:05 ` Christoph Hellwig [this message]
2016-10-24 11:45 ` Jan Kara
2016-10-21 11:55 ` [PATCH 2/4] direct-io: Use unmap_underlying_metadata_ext() instead of handmade iteration Jan Kara
2016-10-21 11:55 ` [PATCH 3/4] ext4: Use unmap_underlying_metadata_ext() instead of iteration Jan Kara
2016-10-21 11:55 ` [PATCH 4/4] ext2: " Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161021120542.GA20475@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).