From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Fabian Frederick <fabf@skynet.be>
Cc: tytso@mit.edu, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/1 linux-next] ext4: fix block_validity definition
Date: Sun, 23 Oct 2016 13:10:03 -0700 [thread overview]
Message-ID: <20161023201003.GA5245@birch.djwong.org> (raw)
In-Reply-To: <1477251814-9938-1-git-send-email-fabf@skynet.be>
On Sun, Oct 23, 2016 at 09:43:34PM +0200, Fabian Frederick wrote:
> Fix ext4 documentation according to commit 45f1a9c3f63d
> ("ext4: enable block_validity by default")
>
> Also fix some typos.
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> Documentation/filesystems/ext4.txt | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/filesystems/ext4.txt b/Documentation/filesystems/ext4.txt
> index 6c0108e..024c6db 100644
> --- a/Documentation/filesystems/ext4.txt
> +++ b/Documentation/filesystems/ext4.txt
> @@ -351,14 +351,13 @@ nouid32 Disables 32-bit UIDs and GIDs. This is for
> interoperability with older kernels which only
> store and expect 16-bit values.
>
> -block_validity This options allows to enables/disables the in-kernel
> +block_validity(*) This option allows to enable/disable the in-kernel
This sentence still reads awkwardly. How about:
"These options enable or disable the in-kernel facility for tracking..."
The rest looks ok, so
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> noblock_validity facility for tracking filesystem metadata blocks
> within internal data structures. This allows multi-
> block allocator and other routines to quickly locate
> extents which might overlap with filesystem metadata
> - blocks. This option is intended for debugging
> - purposes and since it negatively affects the
> - performance, it is off by default.
> + blocks. Initially intended for debugging, it's now
> + enabled by default.
>
> dioread_lock Controls whether or not ext4 should use the DIO read
> dioread_nolock locking. If the dioread_nolock option is specified
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-10-23 20:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-23 19:43 [PATCH 1/1 linux-next] ext4: fix block_validity definition Fabian Frederick
2016-10-23 20:10 ` Darrick J. Wong [this message]
2016-12-03 21:44 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161023201003.GA5245@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=fabf@skynet.be \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).