From: Theodore Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Chandan Rajendra <chandan@linux.vnet.ibm.com>,
linux-ext4@vger.kernel.org, jack@suse.cz,
aneesh.kumar@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] ext4: ext4_mb_mark_free_simple: Fix integer value truncation
Date: Mon, 14 Nov 2016 21:24:20 -0500 [thread overview]
Message-ID: <20161115022420.7bgsyq3yz6sxv3sk@thunk.org> (raw)
In-Reply-To: <2AE0DCBF-5AB6-47B2-B9F6-B738AFF2EAF2@dilger.ca>
On Thu, Nov 03, 2016 at 01:32:33PM -0600, Andreas Dilger wrote:
> On Nov 3, 2016, at 3:14 AM, Chandan Rajendra <chandan@linux.vnet.ibm.com> wrote:
> >
> > 'border' variable is set to a value of 2 times the block size of the
> > underlying filesystem. With 64k block size, the resulting value won't
> > fit into a 16-bit variable. Hence this commit changes the data type of
> > 'border' to 'unsigned int'.
> >
> > Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
>
> Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Applied, with a change in the commit summary:
ext4: fix mballoc breakage with 64k block size
Many thanks!!
- Ted
prev parent reply other threads:[~2016-11-15 2:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 9:14 [PATCH] ext4: ext4_mb_mark_free_simple: Fix integer value truncation Chandan Rajendra
2016-11-03 19:32 ` Andreas Dilger
2016-11-15 2:24 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161115022420.7bgsyq3yz6sxv3sk@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=chandan@linux.vnet.ibm.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox