On Wed 23-11-16 08:33:16, Dave Chinner wrote: > > diff --git a/fs/ext4/Kconfig b/fs/ext4/Kconfig > > index e38039fd96ff..7b90691e98c4 100644 > > --- a/fs/ext4/Kconfig > > +++ b/fs/ext4/Kconfig > > @@ -37,6 +37,7 @@ config EXT4_FS > > select CRC16 > > select CRYPTO > > select CRYPTO_CRC32C > > + select FS_IOMAP if FS_DAX > > Shouldn't the FS_DAX config select FS_IOMAP unconditionally because > it is now a hard config dependency in the DAX subsystem? Yeah, that would be even better. Ted, can you add this cleanup patch as well (attached)? Possibly also just ditch my previous ext4-specific patch and remove relevant hunk from the attached one. Thanks! Honza -- Jan Kara SUSE Labs, CR