From: Tejun Heo <tj@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Tejun Heo <htejun@fb.com>,
torvalds@linux-foundation.org, akpm@linux-foundation.org,
mingo@redhat.com, axboe@kernel.dk, tytso@mit.edu, jack@suse.com,
adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com, mingbo@fb.com
Subject: Re: [PATCH 1/4] sched: move IO scheduling accounting from io_schedule_timeout() to __schedule()
Date: Tue, 6 Dec 2016 16:30:32 -0500 [thread overview]
Message-ID: <20161206213032.GC26314@mtj.duckdns.org> (raw)
In-Reply-To: <20161031164556.GC26364@mtj.duckdns.org>
Hello,
On Mon, Oct 31, 2016 at 10:45:56AM -0600, Tejun Heo wrote:
> Tracking the owners of mutexes and rwsems does help quite a bit. I
> don't think it's as simple as inheriting io sleep state from the
> current owner tho. The owner might be running or in a non-IO sleep
> when others try to grab the mutex. It is an option to ignore those
> cases but this would have a real possibility to lead to surprising
> results in some corner cases. If we choose to propagate dynamically,
> it becomes an a lot more complex problem and I don't think it'd be
> justfiable.
>
> Unless there can be a simple enough and reliable solution, I think
> it'd be better to stick with explicit marking.
Just posted the fixed version for the first patch. Any more thoughts
on this?
Thanks.
--
tejun
next prev parent reply other threads:[~2016-12-06 21:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 16:58 [PATCHSET RFC] sched, jbd2: mark sleeps on journal->j_checkpoint_mutex as iowait Tejun Heo
2016-10-28 16:58 ` [PATCH 1/4] sched: move IO scheduling accounting from io_schedule_timeout() to __schedule() Tejun Heo
2016-10-28 18:27 ` Peter Zijlstra
2016-10-28 19:07 ` Peter Zijlstra
2016-10-28 19:12 ` Tejun Heo
2016-10-29 3:21 ` Peter Zijlstra
2016-10-31 16:45 ` Tejun Heo
2016-12-06 21:30 ` Tejun Heo [this message]
2016-11-03 15:33 ` Pavan Kondeti
2016-11-08 22:51 ` Tejun Heo
2016-12-06 21:29 ` [PATCH v2 " Tejun Heo
2016-12-07 9:35 ` Peter Zijlstra
2016-12-07 20:48 ` [PATCH v3 1/4] sched: move IO scheduling accounting from io_schedule_timeout() into scheduler Tejun Heo
2016-10-28 16:58 ` [PATCH 2/4] sched: separate out io_schedule_prepare() and io_schedule_finish() Tejun Heo
2016-10-28 16:58 ` [PATCH 3/4] mutex: add mutex_lock_io() Tejun Heo
2016-10-28 16:58 ` [PATCH 4/4] jbd2: use mutex_lock_io() for journal->j_checkpoint_mutex Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206213032.GC26314@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=htejun@fb.com \
--cc=jack@suse.com \
--cc=kernel-team@fb.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingbo@fb.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).