* Re: [PATCH] ubifs: add CONFIG_BLOCK dependency for encryption
[not found] <20161216084231.1637761-1-arnd@arndb.de>
@ 2016-12-16 9:26 ` Richard Weinberger
2016-12-16 9:35 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Richard Weinberger @ 2016-12-16 9:26 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Artem Bityutskiy, Adrian Hunter, linux-mtd, linux-kernel,
Ext4 Developers List, Theodore Ts'o, Eric Biggers,
David Gstir, Randy Dunlap
Arnd,
On 16.12.2016 09:42, Arnd Bergmann wrote:
> This came up during the v4.10 merge window:
>
> warning: (UBIFS_FS_ENCRYPTION) selects FS_ENCRYPTION which has unmet direct dependencies (BLOCK)
> fs/crypto/crypto.c: In function 'fscrypt_zeroout_range':
> fs/crypto/crypto.c:355:9: error: implicit declaration of function 'bio_alloc';did you mean 'd_alloc'? [-Werror=implicit-function-declaration]
> bio = bio_alloc(GFP_NOWAIT, 1);
>
> The easiest way out is to limit UBIFS_FS_ENCRYPTION to configurations
> that also enable BLOCK.
Thanks for the fix!
I'll queue this for -rc2.
In the long-run I'd like to remove the CONFIG_BLOCK dependency from fs/crypto/crypto.c
since UBIFS does not use the block related functions at all.
Thanks,
//richard
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ubifs: add CONFIG_BLOCK dependency for encryption
2016-12-16 9:26 ` [PATCH] ubifs: add CONFIG_BLOCK dependency for encryption Richard Weinberger
@ 2016-12-16 9:35 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2016-12-16 9:35 UTC (permalink / raw)
To: Richard Weinberger
Cc: Arnd Bergmann, Artem Bityutskiy, Adrian Hunter, linux-mtd,
linux-kernel, Ext4 Developers List, Theodore Ts'o,
Eric Biggers, David Gstir, Randy Dunlap
On Fri, Dec 16, 2016 at 10:26:35AM +0100, Richard Weinberger wrote:
> > The easiest way out is to limit UBIFS_FS_ENCRYPTION to configurations
> > that also enable BLOCK.
>
> Thanks for the fix!
> I'll queue this for -rc2.
>
> In the long-run I'd like to remove the CONFIG_BLOCK dependency from fs/crypto/crypto.c
> since UBIFS does not use the block related functions at all.
I would much prefer if you did that fixup now. Either by moving
all the block code into a new fs/crypto/bio.c or if that's too hard
by just sprinkling ifdefs.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-16 9:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20161216084231.1637761-1-arnd@arndb.de>
2016-12-16 9:26 ` [PATCH] ubifs: add CONFIG_BLOCK dependency for encryption Richard Weinberger
2016-12-16 9:35 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).