From: Christoph Hellwig <hch@infradead.org>
To: Eryu Guan <eguan@redhat.com>
Cc: linux-block@vger.kernel.org, chaitanya.kulkarni@hgst.com,
linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [BUG v4.10-rc1] fzero returns EIO on DAX mount
Date: Fri, 13 Jan 2017 05:21:31 -0800 [thread overview]
Message-ID: <20170113132131.GA19088@infradead.org> (raw)
In-Reply-To: <20170106103239.GY1859@eguan.usersys.redhat.com>
The problem is that brd return -EIO due to alignment, and the old
code waited for the bio and then ignored the error. The new code
assumes if the submission is fine this is the method to pick and to
move on. We could revert some of this for now, but I think the right
thing to do is to stop abusing REQ_OP_DISCARD for zeroing now.
I had planned to do this for 4.10 but it splitted, let's see if I
can get the series small enough for this time in the merge window.
prev parent reply other threads:[~2017-01-13 13:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 10:32 [BUG v4.10-rc1] fzero returns EIO on DAX mount Eryu Guan
2017-01-07 10:57 ` Chaitanya Kulkarni
2017-01-13 13:21 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170113132131.GA19088@infradead.org \
--to=hch@infradead.org \
--cc=chaitanya.kulkarni@hgst.com \
--cc=eguan@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).