From: Theodore Ts'o <tytso@mit.edu>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
fstests <fstests@vger.kernel.org>
Subject: Re: [RFC/PATCH 0/3] Implement XFS's GOINGDOWN ioctl for ext4
Date: Fri, 3 Feb 2017 10:09:14 -0500 [thread overview]
Message-ID: <20170203150914.vkahg2lyfi2ryk26@thunk.org> (raw)
In-Reply-To: <CAOQ4uxhQubTwdOtmXXsaW4hVjKt2yBhSFG92ie0QcO+HGD9ioQ@mail.gmail.com>
On Fri, Feb 03, 2017 at 09:05:01AM +0200, Amir Goldstein wrote:
>
> I have a naive question about generic implementation:
> We already have mnt_want_write() hooks in generic vfs code,
> so it should be easy enough to set the shutdown bit on sb and return -EIO there.
> Wouldn't it be better to add mnt_want_read() hooks in vfs helpers
> instead of duplicating
> the fs specific hooks? I hear f2fs is yet another potential customer??
There are *portions* of shutdown functionality which could be done in
the generic VFS code. The checks to have various system calls return
early, and to have writeback skipped for inodes belonging to that file
system, could be done in the generic code, sure. But the code to
shutdown or abort the journal would always have to be fs specific, for
example.
- Ted
prev parent reply other threads:[~2017-02-03 15:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 22:59 [RFC/PATCH 0/3] Implement XFS's GOINGDOWN ioctl for ext4 Theodore Ts'o
2017-02-02 22:59 ` [RFC/PATCH 1/3] ext4: rename s_resize_flags to s_ext4_flags Theodore Ts'o
2017-02-02 22:59 ` [RFC/PATCH 2/3] ext4: add shutdown bit and check for it Theodore Ts'o
2017-02-02 22:59 ` [RFC/PATCH 3/3] ext4: add EXT4_IOC_GOINGDOWN ioctl Theodore Ts'o
2017-02-03 0:02 ` Darrick J. Wong
2017-02-03 2:22 ` Theodore Ts'o
2017-02-03 7:05 ` [RFC/PATCH 0/3] Implement XFS's GOINGDOWN ioctl for ext4 Amir Goldstein
2017-02-03 15:09 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170203150914.vkahg2lyfi2ryk26@thunk.org \
--to=tytso@mit.edu \
--cc=amir73il@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox