From: Theodore Ts'o <tytso-3s7WtUTddSA@public.gmane.org>
To: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org,
linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>,
Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Subject: Re: [PATCH 1/2] ext4: fix DAX write locking
Date: Wed, 8 Feb 2017 14:38:32 -0500 [thread overview]
Message-ID: <20170208193832.zydlsh64ieage2js@thunk.org> (raw)
In-Reply-To: <20170208171410.GA27359-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
On Wed, Feb 08, 2017 at 09:14:10AM -0800, Christoph Hellwig wrote:
> On Wed, Jan 11, 2017 at 10:01:36AM +0100, Jan Kara wrote:
> > On Tue 10-01-17 16:48:07, Christoph Hellwig wrote:
> > > Unlike O_DIRECT DAX is not an optional opt-in feature selected by the
> > > application, so we'll have to provide the traditional synchronіzation
> > > of overlapping writes as we do for buffered writes.
> > >
> > > This was broken historically for DAX, but got fixed for ext2 and XFS
> > > as part of the iomap conversion. Fix up ext4 as well.
> > >
> > > Signed-off-by: Christoph Hellwig <hch@lst.de>
> >
> > Makes sense. You can add:
> >
> > Reviewed-by: Jan Kara <jack@suse.cz>
> >
> > Ted, can you please pick it up? Thanks!
>
> Did this get picked up?
Sorry, I missed Jan's request to pick it up. I had assumed it would
be going in via the dax tree. I'll take a look at it now for the ext4
tree.
- Ted
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2017-02-08 19:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 15:48 fix write synchronization for DAX Christoph Hellwig
2017-01-10 15:48 ` [PATCH 1/2] ext4: fix DAX write locking Christoph Hellwig
2017-01-11 9:01 ` Jan Kara
[not found] ` <20170111090136.GE16116-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2017-02-08 17:14 ` Christoph Hellwig
[not found] ` <20170208171410.GA27359-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-02-08 19:38 ` Theodore Ts'o [this message]
2017-02-08 19:41 ` Theodore Ts'o
2017-01-10 15:48 ` [PATCH 2/2] dax: assert that i_rwsem is held exclusive for writes Christoph Hellwig
2017-01-11 9:02 ` Jan Kara
[not found] ` <20170111090250.GF16116-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2017-02-08 19:43 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170208193832.zydlsh64ieage2js@thunk.org \
--to=tytso-3s7wtutddsa@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=jack-AlSwsSmVLrQ@public.gmane.org \
--cc=linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox