* [PATCH] e2fsprogs: remove duplicate default values in mke2fs.conf
@ 2017-02-11 15:15 Xose Vazquez Perez
2017-02-16 16:28 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Xose Vazquez Perez @ 2017-02-11 15:15 UTC (permalink / raw)
Cc: Xose Vazquez Perez, Theodore Ts'o, EXT4 ml
Cc: Theodore Ts'o <tytso@mit.edu>
Cc: EXT4 ml <linux-ext4@vger.kernel.org>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
misc/mke2fs.conf.in | 3 ---
1 file changed, 3 deletions(-)
diff --git a/misc/mke2fs.conf.in b/misc/mke2fs.conf.in
index 812f7c74..3d612594 100644
--- a/misc/mke2fs.conf.in
+++ b/misc/mke2fs.conf.in
@@ -12,11 +12,9 @@
}
ext4 = {
features = has_journal,extent,huge_file,flex_bg,uninit_bg,64bit,dir_nlink,extra_isize
- inode_size = 256
}
ext4dev = {
features = has_journal,extent,huge_file,flex_bg,uninit_bg,inline_data,64bit,dir_nlink,extra_isize
- inode_size = 256
options = test_fs=1
}
small = {
@@ -47,6 +45,5 @@
blocksize = -1
}
hurd = {
- blocksize = 4096
inode_size = 128
}
--
2.11.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] e2fsprogs: remove duplicate default values in mke2fs.conf
2017-02-11 15:15 [PATCH] e2fsprogs: remove duplicate default values in mke2fs.conf Xose Vazquez Perez
@ 2017-02-16 16:28 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2017-02-16 16:28 UTC (permalink / raw)
To: Xose Vazquez Perez; +Cc: EXT4 ml
On Sat, Feb 11, 2017 at 04:15:35PM +0100, Xose Vazquez Perez wrote:
> @@ -12,11 +12,9 @@
> }
> ext4 = {
> features = has_journal,extent,huge_file,flex_bg,uninit_bg,64bit,dir_nlink,extra_isize
> - inode_size = 256
> }
> ext4dev = {
> features = has_journal,extent,huge_file,flex_bg,uninit_bg,inline_data,64bit,dir_nlink,extra_isize
> - inode_size = 256
> options = test_fs=1
> }
> small = {
These are duplicate values (although they don't do any harm).
> @@ -47,6 +45,5 @@
> blocksize = -1
> }
> hurd = {
> - blocksize = 4096
> inode_size = 128
> }
This value *is* required. The Hurd has a re-implementation of the
ext2/3/4 file system, which is very limited. One of its limitations
is the block size must be equal to the page size (and it only works on
x86.) So the "blocksize = 4096" is required so that:
mke2fs -o hurd /tmp/foo.img 1024
will use a 4k block size even for small file systems.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-16 16:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-11 15:15 [PATCH] e2fsprogs: remove duplicate default values in mke2fs.conf Xose Vazquez Perez
2017-02-16 16:28 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).