linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Benjamin Peterson <bp@benjamin.pe>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: fix spelling of "don't"
Date: Sat, 25 Mar 2017 15:55:13 -0400	[thread overview]
Message-ID: <20170325195513.uugak4xknknob6p5@thunk.org> (raw)
In-Reply-To: <1490073611.313465.918041856.1A5E4239@webmail.messagingengine.com>

On Mon, Mar 20, 2017 at 10:20:11PM -0700, Benjamin Peterson wrote:
> Signed-off-by: Benjamin Peterson <bp@benjamin.pe>

Hi Benjamin,

	I generally don't take spelling fixes unless it's part of a
related code change.  If you are a beginning kernel developer, most of
kernelnewbies tutorials advise beginners to send patches to the code
in the drivers/staging directory.

Also, please note that this patch arrived white-space damaged.  I'm
guessing it's because you are using a web-based engine, and it
line-wraped the patch, thus damaging it:

> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 7385e6a..4247d8d 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -5400,7 +5400,7 @@ int ext4_getattr(const struct path *path, struct
> kstat *stat,
>  	 * If there is inline data in the inode, the inode will normally
>  	 not
         ^^^^ webmail damage
>  	 * have data blocks allocated (it may have an external xattr
>  	 block).
         ^^^^ webmail damage

>  	 * Report at least one sector for such files, so tools like tar,
>  	 rsync,
         ^^^^ webmail damage
> -        * others doen't incorrectly think the file is completely
> sparse.
  ^^^^ webmail damage
> +        * others don't incorrectly think the file is completely sparse.
>  	 */
>  	if (unlikely(ext4_has_inline_data(inode)))
>  		stat->blocks += (stat->size + 511) >> 9;

Cheers,

					- Ted

      reply	other threads:[~2017-03-25 19:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-21  5:20 [PATCH] ext4: fix spelling of "don't" Benjamin Peterson
2017-03-25 19:55 ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170325195513.uugak4xknknob6p5@thunk.org \
    --to=tytso@mit.edu \
    --cc=bp@benjamin.pe \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).