From: Theodore Ts'o <tytso@mit.edu>
To: Artem Blagodarenko <artem.blagodarenko@seagate.com>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
Theodore Ts'o <tytso@mit.edu>
Subject: [PATCH] e2fsck: fix type mismatch bug in the largedir patch
Date: Fri, 14 Apr 2017 16:56:40 -0400 [thread overview]
Message-ID: <20170414205640.31710-1-tytso@mit.edu> (raw)
Commit ae9efd05a986: "e2fsck: 3 level hash tree directory
optimization" introduced a bug when checking for the largedir feature.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
I should have noticed the build warning sooner, but then again, so the
patch author should have as well. :-)
e2fsck/pass2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/e2fsck/pass2.c b/e2fsck/pass2.c
index fc98e833..09b79c3b 100644
--- a/e2fsck/pass2.c
+++ b/e2fsck/pass2.c
@@ -978,7 +978,7 @@ static int check_dir_block(ext2_filsys fs,
* very large and then the files are deleted. For now, all that is
* needed is to avoid e2fsck filling in these holes as part of
* feature flag. */
- if (db->blk == 0 && ext2fs_has_feature_largedir(fs))
+ if (db->blk == 0 && ext2fs_has_feature_largedir(fs->super))
return 0;
if (db->blk == 0 && !inline_data_size) {
--
2.11.0.rc0.7.gbe5a750
next reply other threads:[~2017-04-14 20:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-14 20:56 Theodore Ts'o [this message]
2017-04-14 21:25 ` [PATCH] e2fsck: fix type mismatch bug in the largedir patch Artem Blagodarenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170414205640.31710-1-tytso@mit.edu \
--to=tytso@mit.edu \
--cc=artem.blagodarenko@seagate.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox